-
-
Notifications
You must be signed in to change notification settings - Fork 63
Implement a simple github webook server to build the doc. #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ewdurbin I'm trying to implement a simple github webhook server for docs.python.org to build the doc when a branch change. (Yes I added a lock to avoid two successive commits to build the same branch at the same time, but no, I did not implemented a queue to ensure all commits are correctly built, the first one is build, the 2nd one is dropped due to process already running, it's a first try.) It would need basic config server side, my 2020 preference would go for something like:
---
version: 1
disable_existing_loggers: false
formatters:
normal:
format: '%(asctime)s - %(levelname)s - %(message)s'
handlers:
file:
class: logging.FileHandler
filename: /var/log/docsbuild/server.log
level: DEBUG
formatter: normal
loggers:
build_docs_server:
level: DEBUG
handlers: [file]
aiohttp.access:
level: DEBUG
handlers: [file]
aiohttp.client:
level: DEBUG
handlers: [file]
aiohttp.internal:
level: DEBUG
handlers: [file]
aiohttp.server:
level: DEBUG
handlers: [file]
aiohttp.web:
level: DEBUG
handlers: [file]
aiohttp.websocket:
level: DEBUG
handlers: [file] The service could look like:
⚠ my code do not chmod the All of this is obviously just my vague idea on how to do it, but I'll follow you if you have any other idea of handling this. |
FWIW, it looks like the default behavior of gunicorn is to create sockets with |
Started some work on this in python/psf-salt#197 |
@ewdurbin thanks for the review! I applied what was required. the GH_SECRET is expected as an environment variable, tell me if you prefer HOST/PORT/PATH as an environment variable for "consistency" of if it's OK to keep them as command line arguments. (or the other way around by using setproctitle to hide the secret from the command...) I'm still using my "good old fork", trying to keep things simple and easy for the first version, but I took the time to wait for childs to avoid hords of zombies, hope it's OK :P |
Hi @ewdurbin is there anything blocking on your side? Can we merge this and try it? |
2caf1f3
to
2ea1381
Compare
closes #98 #77