10000 gh-861: Document GitHub CLI by za · Pull Request #882 · python/devguide · GitHub
[go: up one dir, main page]

Skip to content

gh-861: Document GitHub CLI #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 1, 2022
Merged

Conversation

za
Copy link
Contributor
@za za commented Jun 6, 2022

Closes #861

@za za marked this pull request as ready for review June 7, 2022 06:53
@za za requested review from ezio-melotti and Mariatta June 8, 2022 02:52
< 8000 /div>
@za za requested a review from ezio-melotti June 9, 2022 06:28
@erlend-aasland erlend-aasland changed the title gh-861 Document GitHub CLI on gitbootcamp.rst gh-861: Document GitHub CLI Jun 9, 2022
@hugovk
Copy link
Member
hugovk commented Jun 9, 2022

Tip: you can also see a build preview by clicking "Show all checks" and then Details next to Read the Docs:

image

image

@za
Copy link
Contributor Author
za commented Jun 23, 2022

Hi @ezio-melotti once you have the time, can you check the PR again? Thank you.

8000
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions :)

@za
Copy link
Contributor Author
za commented Jun 29, 2022

Thanks for the feedback @hugovk . I've addressed them, please check.

@za za requested a review from hugovk June 29, 2022 07:37
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@za za requested a review from hugovk June 30, 2022 03:19
@za za requested review from hugovk and ezio-melotti July 1, 2022 04:08
@ezio-melotti ezio-melotti merged commit d88bf3a into python:main Jul 1, 2022
@za
Copy link
Contributor Author
za commented Jul 1, 2022

Thanks for the review @ezio-melotti @hugovk @Mariatta ! 🎉

@ezio-melotti
Copy link
Member

Thanks for the PR!

kitarefake added a commit to kitarefake/devguide that referenced this pull request Jul 15, 2024
* gh-861 Initial commit to document GitHub CLI on gitbootcamp.rst

* gh-861 Address feedback

* Numbered list
* ssh formatting
* code block removal

Reference:
python/devguide#882 (review)

* gh-861 Add <pr-id>

* gh-861 Add short description and installation instruction.

* gh-861 Reformat the hyperlink

* gh-861 Make `gh auth login` in a separate section

and fix the broken link.

* gh-861 Address feedback from @hugovk

python/devguide#882 (review)

* gh-861 Make the period not as part of the hyperlink.

* gh-8161 Change to lowercase

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

* gh-861 No need to repeat CLI

Feedback by @hugovk
python/devguide#882 (comment)

* gh-861 Simplified introduction paragraph

Feedback by @ezio-melotti
python/devguide#882 (comment)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document GitHub CLI
4 participants
0