10000 bpo-42349: Clarify basicblocks and give some examples by sweeneyde · Pull Request #714 · python/devguide · GitHub
[go: up one dir, main page]

Skip to content

bpo-42349: Clarify basicblocks and give some examples #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

sweeneyde
Copy link
Member
@sweeneyde sweeneyde commented Jun 13, 2021

This follows dicucssion here: https://bugs.python.org/issue42349

@sweeneyde
Copy link
Member Author

It looks like @brettcannon wrote this doc originally. The compiler implementation details used to allow multiple exits per basic block, but that is "incorrect" for the common definition of basic block, and it was changed in that issue.

@brettcannon brettcannon self-requested a review June 14, 2021 21:30
Copy link
Member
@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply made comment about the markup, did not really review the changed text thoroughly.

I was also wondering if the examples could be something more concrete than f1 or a, b, but I don't have better suggestion. Just a thought.

Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
@brettcannon brettcannon merged commit af52f4b into python:master Jul 16, 2021
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0