8000 devcycle: Clarify doc & test changes in Beta & RC by encukou · Pull Request #676 · python/devguide · GitHub
[go: up one dir, main page]

Skip to content

devcycle: Clarify doc & test changes in Beta & RC #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

encukou
Copy link
Member
@encukou encukou commented Apr 20, 2021

This is how I imagine things work in the beta & RC, but I'm likely wrong:

  • beta: docs & test changes are welcome
  • RC: no trivial changes

@pablogsal, as the RM, could you please review and make any changes necessary?

@pablogsal
Copy link
Member
  • beta: docs & test changes are welcome
  • RC: no trivial changes

@pablogsal, as the RM, could you please review and make any changes necessary?

I think this is correct, at least it matches my current understanding.

@pablogsal
Copy link
Member

Chiming other RMs to double check:

CC: @ambv @ned-deily

@ambv
Copy link
Contributor
ambv commented Apr 20, 2021

I like the clarification that beta still accepts doc and test improvements. I don't like the implication that release candidates don't allow those. Since we squished the beta phase a bit to hit RC1 just in time for inclusion in Fall editions of Linux distributions, we now spend two months of every year in RC phase. Saying that we shouldn't allow for documentation and tests to shape up then is unrealistic.

I understand that we don't want major refactors of tests and docs in RCs but for new functionality it's not uncommon for documentation to only be written when we pester for it while working on the What's New document before the final release -_-

@ned-deily
Copy link
Member

I agree with @ambv. Perhaps change the RC wording to something like: "While the goal is to have no code changes between a RC and a final release, there may be a need for final documentation or test fixes. Any such proposed changes should be discussed first with the release manager."

@encukou
Copy link
Member Author
encukou commented Apr 21, 2021

Thanks for the clarification!

@pablogsal pablogsal merged commit 6127a2b into master Apr 23, 2021
@pablogsal pablogsal deleted the encukou-patch-1-devcycle-doc-test branch April 23, 2021 18:02
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0