Add advice on building all modules on Debian-like #673
Conversation
This comment has been minimized.
This comment has been minimized.
|
@erlend-aasland you 👍 this and the PR has been waiting for a merge for the last couple of months; what can I do to make the last step happen, please? |
|
@Mariatta Do you know linux well enough to review this addition to the linux setup part of the devguide? Or do you know who else commits devguide changes who might? (I am neither.) The idea seem straightforward, and has gotten 4 likes, but from non-committers. |
setup.rst
Outdated
| @@ -341,6 +341,14 @@ Now you can install the build dependencies via ``apt``:: | |||
| If that package is not available for your system, try reducing the minor | |||
| version until you find a package that is available. | |||
|
|
|||
| If you want to build all modules, install these packages in the versions you | |||
| prefer, changing the version name as above:: | |||
There was a problem hiding this comment.
I think this can be combined with the above point, as I'm pretty sure the explicit package names cover everything that would be installed by build-dep. The above point should also be updated to a more recent version (or the minor version removed entirely, and the suggestion amended to suggest adding a minor version if python3 doesn't cut it).
There was a problem hiding this comment.
I have removed the minor version from the Python package for which the command installs the build dependencies.
setup.rst
Outdated
| If you want to build all modules, install these packages in the versions you | ||
| prefer, changing the version name as above:: |
There was a problem hiding this comment.
I'm also not a fan of the "versions you prefer..." bit, I would suggest to trim it back to just
| If you want to build all modules, install these packages in the versions you | |
| prefer, changing the version name as above:: | |
| If you want to build all optional modules, install the following packages and | |
| their dependencies:: |
There was a problem hiding this comment.
I have accepted this suggestion entirely, merging it with the deletion of the previous paragraph.
setup.rst
Outdated
|
|
||
| $ sudo apt-get install build-essential gdb lcov libbz2-dev libffi-dev \ | ||
| libgdbm-dev liblzma-dev libncurses5-dev libreadline6-dev \ | ||
| libsqlite3-dev libssl-dev lzma lzma-dev tk-dev uuid-dev xvfb \ |
There was a problem hiding this comment.
xvfb is not actually necessary, it would only allow you to run Tk tests on a headless machine.
There was a problem hiding this comment.
I have removed xvfb from the list.
|
Thank you @zware for your suggestions, please either Resolve the contextual exchanges or recommend further work needed on the PR. |
Current advice regarding installing dependencies is insufficient to build all optional modules:
Some users may like the convenience of getting a head start on choosing OS packages that get them closer to a complete build.