8000 Fix good commit example to use imperative title by DahlitzFlorian · Pull Request #587 · python/devguide · GitHub
[go: up one dir, main page]
Skip to content

Fix good commit example to use imperative title #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 25, 2020
Merged

Fix good commit example to use imperative title #587

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b5876f
Merge remote-tracking branch 'upstream/master'
DahlitzFlorian May 21, 2020
e6432e1
Fix good commit example to use imperative title
DahlitzFlorian May 21, 2020
a2a902e
Apply suggestions from code review @aeros
DahlitzFlorian May 22, 2020
7d16a28
Apply suggestion made by @terryjreedy
DahlitzFlorian May 24, 2020
2be1ce9
Apply changes suggested by @aeros
DahlitzFlorian May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review @aeros
  • Loading branch information
@DahlitzFlorian
DahlitzFlorian committed May 22, 2020
commit a2a902eda11c9a038e49e04b1c91a0c647f06bea
8 changes: 4 additions & 4 deletions pullrequest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,10 @@ Commit messages should follow the following structure::
raises the amount of spam in the module by making it more spammy.

The first line or sentence is meant to be a dense, to-the-point explanation
of what the purpose of the commit is. The imperative form is strongly
preferred to a descriptive form such as 'the spam module is now more spammy'.
Use ``git log --oneline`` to see existing title lines. Furthermore, the first
line should not end in a period.
of what the purpose of the commit is. The imperative form (used in the example
above) is strongly preferred to a descriptive form such as 'the spam module is
now more spammy'. Use ``git log --oneline`` to see existing title lines.
Furthermore, the first line should not end in a period.

If this is not enough detail for a commit, a new paragraph(s) can be added
to explain in proper depth what has happened (detail should be good enough
Expand Down
0