10000 Bump macOS build recommendations to OpenSSL v3.0 by erlend-aasland · Pull Request #1112 · python/devguide · GitHub
[go: up one dir, main page]
Skip to content

Bump macOS build recommendations to OpenSSL v3.0 #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2023
Merged

Bump macOS build recommendations to OpenSSL v3.0 #1112

merged 2 commits into from
Jun 9, 2023

Conversation

erlend-aasland
Copy link
Contributor
@erlend-aasland erlend-aasland commented Jun 8, 2023 •
edited
Loading

Fixes #1111

📚 Documentation preview 📚: https://cpython-devguide--1112.org.readthedocs.build/

@erlend-aasland erlend-aasland requested a review from ned-deily June 8, 2023 22:24
@erlend-aasland erlend-aasland linked an issue Jun 8, 2023 that may be closed by this pull request
Update macOS build recommendations to use OpenSSL 3.0 #1111
Closed
@erlend-aasland erlend-aasland changed the title gh-1111: Bump macOS build recommendations to OpenSSL v3.0 Bump macOS build recommendations to OpenSSL v3.0 Jun 8, 2023
@erlend-aasland erlend-aasland mentioned this pull request Jun 8, 2023
Merged
@ned-deily
Simplify recipes by:
d7443d1 
1. removing references to 3.7 which will be end-of-life shortly
   and otherwise would require including OpenSSL 1.1.1 libs.
2. removing MacPorts recipe for 3.10 and earlier because there
   are conflicts with the use of --with-openssl and the use of
   CPPFLAGS/LDFLAGS.
ned-deily
ned-deily reviewed Jun 8, 2023
View reviewed changes
Copy link
Member
@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've pushed some changes to the PR. Rather than try to differentiate between OpenSSL 1.1.1 and 3.x, which would complicate things (like the brew installs) and since we want to get to 3.0 anyway, let's just bite the bullet here. I've also simplified the MacPorts recipes by removing the suggestion for 3.10 and earlier as that doesn't quite build correctly.

@erlend-aasland
Copy link
Contributor Author

Thanks!

@erlend-aasland
Copy link
Contributor Author

LGTM

@erlend-aasland erlend-aasland merged commit 7620395 into python:main Jun 9, 2023
@erlend-aasland erlend-aasland deleted the macos-openssl3 branch June 9, 2023 04:56
@ezio-melotti ezio-melotti mentioned this pull request Jul 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily left review comments

Assignees
No one assigned
Labels
None yet
Projects
OpenSSL 3
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update macOS build recommendations to use OpenSSL 3.0
2 participants
@erlend-aasland @ned-deily
0