-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-91133: tempfile.TemporaryDirectory: fix symlink bug in cleanup #99930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d8f50e5
tempfile tests: try not to leave NOUNLINK files behind
kwi-dk d268947
gh-91133: tempfile.TemporaryDirectory: fix symlink bug in cleanup
kwi-dk 60de13a
NEWS: fix blurb typo
kwi-dk 983a9ac
Revert "tempfile tests: try not to leave NOUNLINK files behind"
kwi-dk 5b83afe
Apply suggestions from code review
kwi-dk db40615
Run test even when chmod doesn't support follow_symlinks
kwi-dk 96124ef
Merge branch 'main' into fix-91133
kwi-dk 1aadbdd
Merge branch 'main' into fix-91133
serhiy-storchaka cb9aea4
Rewrite tests.
serhiy-storchaka f106e25
Fix on Windows.
serhiy-storchaka 0be03d1
Add a test for file flags.
serhiy-storchaka 0a05de0
Address review comments.
serhiy-storchaka 081a898
Merge branch 'main' into fix-91133
serhiy-storchaka 58924b6
Update Lib/tempfile.py
serhiy-storchaka b88478f
Address review comments.
serhiy-storchaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add a test for file flags.
- Loading branch information
commit 0be03d13307ebe9483efcaeae09496e00a13874e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can pass flags to check_flags(), rather than having a copy inside the function. I also suggest moving the comment here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not want to repeat the same comment 3 times.