8000 Improve sqlite3 documentation of the new autocommit attribute by geryogam · Pull Request #99435 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Improve sqlite3 documentation of the new autocommit attribute #99435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Improve sqlite3 documentation of the new autocommit attribute #99435

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bb30103
Remove an unnecessary lambda in tests
geryogam Nov 13, 2022
261f21b
Clarify that implicit open or roll back happens in the same method call
geryogam Nov 13, 2022
d864934
Add connect() to the list of implicit-transaction-opening methods
geryogam Nov 21, 2022
8b250c0
Recommend commit() and rollback() in legacy manual commit mode
geryogam Nov 21, 2022
d11dcfb
Clarify PEP-249-compliant vs legacy transaction control
geryogam Nov 21, 2022
3750bf0
Improve wording consistency
geryogam Nov 21, 2022
b9034b1
Remove two ambiguous ‘underlying’
geryogam Nov 13, 2022
55a28c8
Normalize ‘open transaction’
geryogam Nov 13, 2022
6db7b57
Normalize ’transaction control’
geryogam Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Normalize ‘open transaction’
  • Loading branch information
@geryogam
geryogam committed Nov 22, 2022
commit 55a28c85bc733480adbf74e9b144f1637520e435
8 changes: 4 additions & 4 deletions Doc/library/sqlite3.rst
D733
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,15 +634,15 @@ Connection objects

.. method:: commit()

Commit any pending transaction to the database.
Commit any open transaction to the database.
If :attr:`autocommit` is ``True``, or there is no open transaction,
this method does nothing.
If :attr:`!autocommit` is ``False``, this method implicitly opens
a new transaction after committing.

.. method:: rollback()

Roll back to the start of any pending transaction.
Roll back to the start of any open transaction.
If :attr:`autocommit` is ``True``, or there is no open transaction,
this method does nothing.
If :attr:`!autocommit` is ``False``, this method implicitly opens
Expand Down Expand Up @@ -1272,7 +1272,7 @@ Connection objects
This is currently the default value of :attr:`!autocommit`.

Changing :attr:`!autocommit` to ``False`` will open a new transaction,
and changing it to ``True`` will commit any pending transaction.
and changing it to ``True`` will commit any open transaction.

See :ref:`sqlite3-transaction-control-autocommit` for more details.

Expand Down Expand Up @@ -1473,7 +1473,7 @@ Cursor objects
Execute the SQL statements in *sql_script*.
If the :attr:`~Connection.autocommit` is
:data:`LEGACY_TRANSACTION_CONTROL`
and there is a pending transaction,
and there is an open transaction,
an implicit ``COMMIT`` statement is executed first.
No other implicit transaction control is performed;
any transaction control must be added to *sql_script*.
Expand Down
0