8000 gh-81057: Move the Extension Modules Cache to _PyRuntimeState by ericsnowcurrently · Pull Request #99355 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-81057: Move the Extension Modules Cache to _PyRuntimeState #99355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 11, 2022
Merged

gh-81057: Move the Extension Modules Cache to _PyRuntimeState #99355

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e21e012
Add a comment describing PyInterpreterState.modules_by_index.
ericsnowcurrently Nov 10, 2022
453ca0e
Add comments describing the PyModuleDef_Base fields.
ericsnowcurrently Nov 10, 2022
3b93ab9
Add _PyRuntimeState.imports.extensions.
ericsnowcurrently Nov 10, 2022
b3e3f45
Switch to _extensions_cache_*().
ericsnowcurrently Nov 10, 2022
1663bfc
Add _PyRuntimeState.imports.last_module_index.
ericsnowcurrently Nov 10, 2022
67dff4d
Refer to the modules_by_index comment.
ericsnowcurrently Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add a comment describing PyInterpreterState.modules_by_index.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Nov 10, 2022
commit e21e012a22b20f35c13826b15ecfcf8f81f8c60f
19 changes: 19 additions & 0 deletions Include/internal/pycore_interp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,25 @@ struct _is {

// sys.modules dictionary
PyObject *modules;
/* This is the list of module objects for all legacy (single-phase init)
extension modules ever loaded in this process (i.e. imported
in this interpreter or in any other). Py_None stands in for
modules that haven't actually been imported in this interpreter.

A module's index (PyModuleDef.m_base.m_index) is used to look up
the corresponding module object for this interpreter, if any.
(See PyState_FindModule().) When any extension module
is initialized during import, its moduledef gets initialized by
PyModuleDef_Init(), and the first time that happens for each
PyModuleDef, its index gets set to the current value of
a global counter (see _PyRuntimeState.imports.last_module_index).
The entry for that index in this interpreter remains unset until
the module is actually imported here. (Py_None is used as
a placeholder.) Note that multi-phase init modules always get
an index for which there will never be a module set.

This is initialized lazily in _PyState_AddModule(), which is also
where modules get added. */
PyObject *modules_by_index;
// Dictionary of the sys module
PyObject *sysdict;
Expand Down
0