8000 gh-98931: Improve error message when the user types 'import x from y' instead of 'from y import x' by pablogsal · Pull Request #98932 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-98931: Improve error message when the user types 'import x from y' instead of 'from y import x' #98932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2022
Merged

gh-98931: Improve error message when the user types 'import x from y' instead of 'from y import x' #98932

merged 4 commits into from
Nov 1, 2022

Conversation

pablogsal
Copy link
Member
@pablogsal pablogsal commented Oct 31, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Oct 31, 2022
Closed
lysnikolaou
lysnikolaou reviewed Oct 31, 2022
View reviewed changes
Copy link
Member
@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! Just one suggestion for the error message.

Grammar/python.gram Outdated
@@ -1230,6 +1233,10 @@ invalid_group:
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "cannot use starred expression here") }
| '(' a='**' expression ')' {
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "cannot use double starred expression here") }
invalid_import:
| a='import' dotted_name 'from' dotted_name {
RAISE_SYNTAX_ERROR_STARTING_FROM(a, "Did you meant to use 'from ... import ...' instead?") }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto in tests and docs.

Suggested change
RAISE_SYNTAX_ERROR_STARTING_FROM(a, "Did you meant to use 'from ... import ...' instead?") }
RAISE_SYNTAX_ERROR_STARTING_FROM(a, "Did you mean to use 'from ... import ...' instead?") }

Copy link
Member Author
@pablogsal pablogsal Oct 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks for the review :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! I think you missed the one in whatsnew?

@pablogsal
fixup! pythongh-98931: Improve error message when the user types 'imp…
207d6e1 
…ort x from y' instead of 'from y import x'
@pablogsal
fixup! fixup! pythongh-98931: Improve error message when the user typ…
fb08d31 
…es 'import x from y' instead of 'from y import x'
@pablogsal
Copy link
Member Author

Will fix the doctest tomorrow

CharlieZhao95
CharlieZhao95 reviewed Nov 1, 2022
View reviewed changes
@pablogsal @CharlieZhao95
Update Doc/whatsnew/3.12.rst
9f705af 
Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
lysnikolaou
lysnikolaou approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member
@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

@pablogsal pablogsal merged commit 395d428 into python:main Nov 1, 2022
@pablogsal pablogsal deleted the gh-98931 branch November 1, 2022 13:01
@pablogsal
Copy link
Member Author

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieZhao95 CharlieZhao95 CharlieZhao95 left review comments

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve syntax error for invalid imports
4 participants
@pablogsal @lysnikolaou @CharlieZhao95 @bedevere-bot
0