10000 GH-98543: Fix `asyncio.TaskGroup` to not keep reference to errors after raising ExceptionGroup by kumaraditya303 · Pull Request #98544 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-98543: Fix asyncio.TaskGroup to not keep reference to errors after raising ExceptionGroup #98544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2022
Merged

GH-98543: Fix asyncio.TaskGroup to not keep reference to errors after raising ExceptionGroup #98544

merged 1 commit into from
Oct 22, 2022

Conversation

kumaraditya303
Copy link
Contributor
@kumaraditya303 kumaraditya303 commented Oct 22, 2022 •
edited by bedevere-bot
Loading

@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error topic-asyncio skip news needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed needs backport to 3.10 only security fixes labels Oct 22, 2022
@kumaraditya303 kumaraditya303 changed the title GH-98543: Fix asyncio.TaskGroup to not keeps references to errors after raising ExceptionGroup GH-98543: Fix asyncio.TaskGroup to not keep reference to errors after raising ExceptionGroup Oct 22, 2022
gvanrossum
gvanrossum approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member
@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@gvanrossum gvanrossum merged commit f4a1494 into python:main Oct 22, 2022
@miss-islington
8000
Copy link
Contributor

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@kumaraditya303 kumaraditya303 deleted the tg branch October 22, 2022 16:05
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2022
@kumaraditya303 @miss-islington
pythonGH-98543: Fix asyncio.TaskGroup to not keep reference to erro…
6cbc00b 
…rs after raising ExceptionGroup (pythonGH-98544)

(cherry picked from commit f4a1494)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303 kumaraditya303 mentioned this pull request Oct 22, 2022
Closed
@gvanrossum
Copy link
Member

Where's the backport? Is Miss Islington confounded?

@AlexWaygood
Copy link
Member
AlexWaygood commented Oct 22, 2022 •
edited
Loading

Where's the backport? Is Miss Islington confounded?

Bedevere usually announced the presence of the backport, so I guess it's him who's confounded, not miss-islington, since miss-islington correctly created a backport here: #98550.

gvanrossum pushed a commit that referenced this pull request Oct 24, 2022
@miss-islington @kumaraditya303
[3.11] GH-98543: Fix asyncio.TaskGroup to not keep reference to err…
36d25a4 
…ors after raising ExceptionGroup (GH-98544) (#98550)

GH-98543: Fix `asyncio.TaskGroup`  to not keep reference to errors after raising ExceptionGroup  (GH-98544)
(cherry picked from commit f4a1494)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@ZeroIntensity ZeroIntensity removed type-bug An unexpected behavior, bug, or error needs backport to 3.11 only security fixes labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

@gvanrossum gvanrossum

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kumaraditya303 @miss-islington @gvanrossum @AlexWaygood @bedevere-bot @ZeroIntensity
0