8000 gh-98507: [typing docs] Rephrase "now supports `[]`" to "now supports subscripting" by sobolevn · Pull Request #98508 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-98507: [typing docs] Rephrase "now supports []" to "now supports subscripting" #98508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2022
Merged

gh-98507: [typing docs] Rephrase "now supports []" to "now supports subscripting" #98508

merged 2 commits into from
Oct 24, 2022

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Oct 21, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 21, 2022
@sobolevn sobolevn changed the title [typing docs] Rephrase "now supports []" to "now supports __class_getitem__" gh-98507: Rephrase "now supports []" to "now supports __class_getitem__" Oct 21, 2022
@sobolevn
Copy link
Member Author

We now have 4 typing reviewers! Awesome ❤️
I wish all modules were as active.

@gvanrossum gvanrossum removed their request for review October 21, 2022 16:57
AlexWaygood
AlexWaygood approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member
@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice improvement -- thanks, @sobolevn!

@AlexWaygood AlexWaygood added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 24, 2022
@AlexWaygood AlexWaygood changed the title gh-98507: Rephrase "now supports []" to "now supports __class_getitem__" gh-98507: [typing docs] Rephrase "now supports []" to "now supports subscripting" Oct 24, 2022
@AlexWaygood AlexWaygood merged commit e3b9dd8 into python:main Oct 24, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@sobolevn @miss-islington
pythongh-98507: [typing docs] Rephrase "now supports []" to "now su…
cbe1b15 
…pports subscripting" (pythonGH-98508)

(cherry picked from commit e3b9dd8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-98616 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 24, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@sobolevn @miss-islington
pythongh-98507: [typing docs] Rephrase "now supports []" to "now su…
9fbf88a 
…pports subscripting" (pythonGH-98508)

(cherry picked from commit e3b9dd8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-98617 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 24, 2022
miss-islington added a commit that referenced this pull request Oct 24, 2022
@miss-islington @sobolevn
gh-98507: [typing docs] Rephrase "now supports []" to "now supports…
cdbfce1 
… subscripting" (GH-98508)

(cherry picked from commit e3b9dd8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Oct 24, 2022
@miss-islington @sobolevn
gh-98507: [typing docs] Rephrase "now supports []" to "now supports…
d79a42a 
… subscripting" (GH-98508)

(cherry picked from commit e3b9dd8)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sobolevn @miss-islington @bedevere-bot @JelleZijlstra @AlexWaygood
0