8000 Change links to label refs by slateny · Pull Request #98454 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Change links to label refs #98454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Change links to label refs #98454

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbf7381
Change links to label refs
slateny Oct 19, 2022
7613ba7
Add missed label and ref
slateny Oct 20, 2022
20fa1fb
Use more specific label name
slateny Oct 20, 2022
9fe6bfd
Change some more links to labels
slateny Oct 21, 2022
6abd61c
Follow convention for label naming, add link to inspect module
slateny Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change some more links to labels
  • Loading branch information
@slateny
slateny committed Oct 21, 2022
commit 9fe6bfda041f47f718fee1d7a57c677db6d4b4ee
4 changes: 2 additions & 2 deletions Doc/using/venv-create.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ re-used.

.. deprecated:: 3.6
``pyvenv`` was the recommended tool for creating virtual environments for
Python 3.3 and 3.4, and is `deprecated in Python 3.6
<https://docs.python.org/dev/whatsnew/3.6.html#id8>`_.
Python 3.3 and 3.4, and is
:ref:`deprecated in Python 3.6 <whatsnew-3.6-venv>`.

.. versionchanged:: 3.5
The use of ``venv`` is now recommended for creating virtual environments.
Expand Down
2 changes: 1 addition & 1 deletion Doc/whatsnew/2.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ This section has just been a quick overview of the new features, giving enough
of an explanation to start you programming, but many details have been
simplified or ignored. Where should you go to get a more complete picture?

https://docs.python.org/dev/howto/descriptor.html is a lengthy tutorial introduction to
The :ref:`descriptorhowto` is a lengthy tutorial introduction to
the descriptor features, written by Guido van Rossum. If my description has
whetted your appetite, go read this tutorial next, because it goes into much
more detail about the new features while still remaining quite easy to read.
Expand Down
2 changes: 2 additions & 0 deletions Doc/whatsnew/3.6.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2052,6 +2052,8 @@ tkinter
The :mod:`tkinter.tix` module is now deprecated. :mod:`tkinter` users
should use :mod:`tkinter.ttk` instead.

.. _whatsnew-3.6-venv:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidenote: Following the convention I've used for the 3.11 What's New would be whatsnew36-venv, but I think this convention (or at least whatsnew3.6-venv) would be better—out of old habit I often avoid using . in ref target labels. In any case, no practical reason to change it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion—I was mentioning this as a sidenote and suggestion you not change it here (instead, I really should be using it in the ref targets I'm adding, though probably too late now for 3.11—I can adopt it with 3.12). But since you have changed it, not really worth changing it again.

Just to be more clear for the future, if I'm actually requesting a change, I will pretty much always make it as a actual suggestion (unless its impractical or impossible), so you can easily apply it with Files -> Add to batch -> Commit rather than manually implementing, committing, pushing and resolving it. The way I see it is if I'm going to ask someone else to make a change on their PR (unless its really important), its only fair that I put in the work myself to implement it, so all they have to do is click a button to accept it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see I see, don't worry too much about it - I checked the existing labels and just decided that it would be good to follow convention. And conversely, I requested the review so I definitely don't mind the work (and I would have to run it locally anyway just to check the rendering), but of course the ease of changing is always appreciated.


venv
~~~~

Expand Down
3 changes: 1 addition & 2 deletions Misc/NEWS.d/3.9.0a3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,8 +805,7 @@ event loop only if called from the main thread.
.. section: Documentation

Add an entry for ``__module__`` in the "function" & "method" sections of the
`inspect docs types and members table
<https://docs.python.org/3/library/inspect.html#types-and-members>`_
:ref:`inspect docs types and members table <inspect-types>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit cleaner to do

Suggested change
:ref:`inspect docs types and members table <inspect-types>`.
:mod:`inspect` docs :ref:`inspect-types` table.


..

Expand 38FD Down
0