8000 Upgrade ccache-action to one using Node 16 by mdboom · Pull Request #98166 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Upgrade ccache-action to one using Node 16 #98166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

Upgrade ccache-action to one using Node 16 #98166

merged 1 commit into from
Oct 11, 2022

Conversation

mdboom
Copy link
Contributor
@mdboom mdboom commented Oct 10, 2022

Github Actions has deprecated the use of Node 12, and will be turning it off by summer 2023.

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

I found this because I have been experimenting with various Github Action things in my own fork and was getting this warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: hendrikmuhs/ccache-action, hendrikmuhs/ccache-action

Unfortunately, we aren't getting this warning on the main CPython fork because there is a bug displaying these warnings in composite actions: actions/runner#1742

Nonetheless, probably worth upgrading this.

@mdboom mdboom requested a review from ezio-melotti as a code owner October 10, 2022 22:37
@mdboom mdboom force-pushed the upgrade-ccache-action branch from 99b8dba to 439edae Compare October 10, 2022 22:39
@AA-Turner AA-Turner added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 11, 2022
@AA-Turner
Copy link
Member

The backport to 3.10 won't be clean, but it should probably be updated too.

@ambv Should this also be backported to 3.8/3.9? Both use ccache-action, and both have end-of-life dates post Summer 2023 so may run in to this.

A

@ambv
Copy link
Contributor
ambv commented Oct 11, 2022

Yes, let's backport 3.8 and 3.9 as well.

@ambv ambv merged commit ad8e297 into python:main Oct 11, 2022
@miss-islington
Copy link
Contributor

Thanks @mdboom for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @mdboom and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ad8e297b7297dfdc34fad53b589b31d0920150ab 3.10

@bedevere-bot
Copy link

GH-98182 is a backport of this pull request to the 3.11 branch.

@miss-islington
Copy link
Contributor

Sorry @mdboom and @ambv, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ad8e297b7297dfdc34fad53b589b31d0920150ab 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 11, 2022
@miss-islington
Copy link
Contributor

Sorry, @mdboom and @ambv, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ad8e297b7297dfdc34fad53b589b31d0920150ab 3.8

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2022
@mdboom @miss-islington
Upgrade ccache-action to one using Node 16 (pythonGH-98166)
5a8e294 
Github Actions has deprecated the use of Node 12, and will be turning it off by
summer 2023.

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
(cherry picked from commit ad8e297)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
@ambv
Copy link
Contributor
ambv commented Oct 11, 2022

I'll make the backports.

miss-islington added a commit that referenced this pull request Oct 15, 2022
@miss-islington @mdboom
Upgrade ccache-action to one using Node 16 (GH-98166)
91bcd21 
Github Actions has deprecated the use of Node 12, and will be turning it off by
summer 2023.

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
(cherry picked from commit ad8e297)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>
@mdboom mdboom deleted the upgrade-ccache-action branch December 22, 2022 15:50
@hugovk
Copy link
Member
hugovk commented Feb 18, 2025

3.9 and 3.10 are using both v1 and v1.2:

3.9/.github/workflows/build.yml
89:        uses: hendrikmuhs/ccache-action@v1
214:      uses: hendrikmuhs/ccache-action@v1
260:      uses: hendrikmuhs/ccache-action@v1.2

3.10/.github/workflows/build.yml
106:        uses: hendrikmuhs/ccache-action@v1
241:      uses: hendrikmuhs/ccache-action@v1
289:      uses: hendrikmuhs/ccache-action@v1.2

Later branches are on v1.2:

3.11/.github/workflows/build.yml
160:        uses: hendrikmuhs/ccache-action@v1.2
275:      uses: hendrikmuhs/ccache-action@v1.2
332:      uses: hendrikmuhs/ccache-action@v1.2

But following GitHub Actions standard practice, the v1 tags is remapped to the latest v1.* tag as well:

https://github.com/hendrikmuhs/ccache-action/tags

So we don't need to backport this any more, and can remove the labels.

@hugovk hugovk removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Assignees

@ambv ambv

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mdboom @AA-Turner @ambv @miss-islington @bedevere-bot @hugovk @ezio-melotti
0