8000 gh-96810: Clarify when sqlite3 implicitly opens transactions by erlend-aasland · Pull Request #96832 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-96810: Clarify when sqlite3 implicitly opens transactions #96832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2022
Merged

gh-96810: Clarify when sqlite3 implicitly opens transactions #96832

merged 1 commit into from
Sep 15, 2022

Conversation

erlend-aasland
Copy link
Contributor
@erlend-aasland erlend-aasland commented Sep 14, 2022 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels Sep 14, 2022
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Sep 14, 2022
@erlend-aasland erlend-aasland linked an issue Sep 14, 2022 that may be closed by this pull request
sqlite3 docs: clarify transaction control for SELECT #96810
Closed
@erlend-aasland
Copy link
Contributor Author

cc. @KennyChenBasis

CAM-Gerlach
CAM-Gerlach approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member
@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland

@erlend-aasland
Copy link
Contributor Author

Thank you for your reviews, CAM and Kenny Chen! 🎉

@erlend-aasland erlend-aasland merged commit 16c33a9 into python:main Sep 15, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-docs/clarify-txn-ctl branch September 15, 2022 21:11
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2022
@erlend-aasland @miss-islington
pythongh-96810: Clarify for which statements sqlite3 implicitly opens…
8031cd3 
… transactions (pythonGH-96832)

(cherry picked from commit 16c33a9)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 15, 2022
@bedevere-bot
Copy link

GH-96854 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2022
@erlend-aasland @miss-islington
pythongh-96810: Clarify for which statements sqlite3 implicitly opens…
7e94c6a 
… transactions (pythonGH-96832)

(cherry picked from commit 16c33a9)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-96855 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 15, 2022
@erlend-aasland erlend-aasland mentioned this pull request Sep 15, 2022
Closed
miss-islington added a commit that referenced this pull request Sep 15, 2022
@miss-islington @erlend-aasland
gh-96810: Clarify for which statements sqlite3 implicitly opens trans…
ec08534 
…actions (GH-96832)

(cherry picked from commit 16c33a9)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Sep 15, 2022
@miss-islington @erlend-aasland
gh-96810: Clarify for which statements sqlite3 implicitly opens trans…
9ab9e82 
…actions (GH-96832)

(cherry picked from commit 16c33a9)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @erlend-aasland @pablogsal
gh-96810: Clarify for which statements sqlite3 implicitly opens trans…
746dad4 
…actions (GH-96832)

(cherry picked from commit 16c33a9)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite3 docs: clarify transaction control for SELECT
4 participants
@erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach
0