8000 gh-96769: Cover more typing special forms to be unsubclassable by sobolevn · Pull Request #96772 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-96769: Cover more typing special forms to be unsubclassable #96772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2022
Merged

gh-96769: Cover more typing special forms to be unsubclassable #96772

merged 1 commit into from
Sep 14, 2022

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Sep 12, 2022 •
edited by bedevere-bot
Loading

I went through all test_cannot_subclass cases and added more assertions.
This PR does not include Annotated because of #96771

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 12, 2022
@gvanrossum
Copy link
Member

Thanks. Do any of the other reviewers have anything to say?

@gvanrossum gvanrossum merged commit 9b3d2d0 into python:main Sep 14, 2022
@allisonkarlitskaya allisonkarlitskaya mentioned this pull request Sep 16, 2022
Open
@kumaraditya303 kumaraditya303 mentioned this pull request Sep 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @gvanrossum @JelleZijlstra @bedevere-bot
0