8000 gh-90751: memoryview now supports half-float by corona10 · Pull Request #96738 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-90751: memoryview now supports half-float #96738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 10, 2022
Merged

gh-90751: memoryview now supports half-float #96738

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
61e926c
gh-90751: memoryview supports half-float
corona10 Sep 10, 2022
2fd17a8
Address code review
corona10 Sep 10, 2022
9e615fd
Add test
corona10 Sep 10, 2022
8bc8754
Add Antoine Pitrou as author too.
corona10 Sep 10, 2022
107bdd2
Update whatsnew
corona10 Sep 10, 2022
343441d
Fix half-float memoryview comparison
pitrou Sep 10, 2022
abf2050
Merge branch 'gh-90751' of https://github.com/corona10/cpython into g…
pitrou Sep 10, 2022
a1ce9d4
Update Doc/whatsnew/3.12.rst
pitrou Sep 10, 2022
e8c1fed
Replace deprecated method for numpy test
corona10 Sep 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address code review
  • Loading branch information
@corona10
corona10 committed Sep 10, 2022
commit 2fd17a86f2d8ffab91e55bb6c7e0f02f6c166c3e
2 changes: 1 addition & 1 deletion Lib/test/test_memoryview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ def test_half_float(self):
float_data = struct.pack('fff', 0.0, -1.5, 1.5)
half_view = memoryview(half_data).cast('e')
float_view = memoryview(float_data).cast('f')
self.assertEqual(half_view.nbytes*2, float_view.nbytes)
self.assertEqual(half_view.nbytes * 2, float_view.nbytes)
self.assertListEqual(half_view.tolist(), float_view.tolist())

def test_memoryview_hex(self):
Expand Down
0