8000 gh-96471: Add queue shutdown by EpicWink · Pull Request #96474 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-96471: Add queue shutdown #96474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

gh-96471: Add queue shutdown #96474

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4fd0640
Add threading implementation of queue shutdown
EpicWink Sep 1, 2022
d942c9e
Fix up implementation, add unit-tests
EpicWink Sep 18, 2022
f552ac1
Implement for asyncio queues
EpicWink Sep 18, 2022
78671f9
WIP: multiprocessing queue shutdown
EpicWink Oct 22, 2022
5f31f8e
WIP: multiprocessing queue shutdown
EpicWink Jan 19, 2023
a2035a6
Merge branch 'main' into queue-shutdown
arhadthedev Feb 9, 2023
978b8d1
Replace try-catch with assert-raises ctx-mgrs
EpicWink Feb 21, 2023
b19f529
WIP: multiprocessing queue shut-down method
EpicWink Feb 21, 2023
6d3b3a5
Use enum for asyncio queue shutdown state
EpicWink Feb 21, 2023
85827f1
Make asyncio queue state private
EpicWink Feb 21, 2023
121de12
Replace try-catch with assert-raises ctx-mgrs
EpicWink Feb 21, 2023
5e2df02
Add asyncio queue tests
EpicWink Feb 21, 2023
14c53d7
Release joined awaitables
EpicWink Feb 21, 2023
da10d9f
Zero unfinished tasks
EpicWink Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace try-catch with assert-raises ctx-mgrs
  • Loading branch information
@EpicWink
EpicWink committed Feb 21, 2023
commit 978b8d1295d74026f3a50a7db8a4852927d14ce1
28 changes: 12 additions & 16 deletions Lib/test/_test_multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,37 +1281,33 @@ def test_closed_queue_put_get_exceptions(self):
def test_shutdown_empty(self):
q = multiprocessing.Queue()
q.shutdown()
try:
with self.assertRaises(
pyqueue.ShutDown, msg="Didn't appear to shut-down queue"
):
q.put("data")
self.fail("Didn't appear to shut-down queue")
except pyqueue.ShutDown:
pass
try:
with self.assertRaises(
pyqueue.ShutDown, msg="Didn't appear to shut-down queue"
):
q.get()
self.fail("Didn't appear to shut-down queue")
except pyqueue.ShutDown:
pass

def test_shutdown_nonempty(self):
q = multiprocessing.Queue()
q.put("data")
q.shutdown()
q.get()
try:
with self.assertRaises(
pyqueue.ShutDown, msg="Didn't appear to shut-down queue"
):
q.get()
self.fail("Didn't appear to shut-down queue")
except pyqueue.ShutDown:
pass

def test_shutdown_immediate(self):
q = multiprocessing.Queue()
q.put("data")
q.shutdown(immediate=True)
try:
with self.assertRaises(
pyqueue.ShutDown, msg="Didn't appear to shut-down queue"
):
q.get()
self.fail("Didn't appear to shut-down queue")
except pyqueue.ShutDown:
pass
#
#
#
Expand Down
0