gh-93678: apply remove_redundant_jumps in optimize_cfg #96274
Conversation
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit d0ffa15 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
So the way it is now, the Gentoo Non-Debug build fails because no_redundant_jumps is not defined: If I remove the |
|
@markshannon how about this version? |
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit e47688a 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Buildbots are fine with it. |
|
I'd rather fix the underlying issue. |
|
Changing the Am I wrong, or the gentoo non-debug build mis-configured somehow? |
|
|
|
as for how it happened in this case, CFLAGS adds -UNDEBUG in https://github.com/python/buildmaster-config/blob/0669211daf34f86e879868364efe15683da0e069/master/custom/factories.py#L277 |
This reverts commit e47688a.
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 065d97d 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Fixes #93678.
Apply remove_redundant_jumps in optimise_cfg because it belongs there. Later in move_cold_blocks_to_end, we may need to apply it again.
Added an assertion just before assembly stage that there are no redundant jumps.
Also tidy up an unrelated error handling issue I spotted.