Minor grammar changes to http.client docs #96221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @erlend-aasland, just wanted to bring this trivial PR to your attention before it was buried. Not sure if you're the one to tag but I noticed you merged a similar PR. Let me know if there's anything to change or if it's good to merge :) |
ezio-melotti
approved these changes
Sep 27, 2022
Contributor
|
Thanks for the PR, @rshah713, and thanks for picking this up, Ezio! |
Contributor
Author
|
No problem! Honored to be able to contribute to such a project I've used so much 👍 |
Contributor
|
Thanks @rshah713 for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-97810 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 3, 2022
Minor grammar changes (cherry picked from commit d053c47) Co-authored-by: Rohan Shah <57906961+rshah713@users.noreply.github.com>
|
GH-97811 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 3, 2022
Minor grammar changes (cherry picked from commit d053c47) Co-authored-by: Rohan Shah <57906961+rshah713@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Oct 3, 2022
Minor grammar changes (cherry picked from commit d053c47) Co-authored-by: Rohan Shah <57906961+rshah713@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Oct 3, 2022
Minor grammar changes (cherry picked from commit d053c47) Co-authored-by: Rohan Shah <57906961+rshah713@users.noreply.github.com>
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2022
Minor grammar changes (cherry picked from commit d053c47) Co-authored-by: Rohan Shah <57906961+rshah713@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small grammatical changes that stood out when reading the
http.clientdocumentation.This is also my first PR to cpython so if there's anything else I need please let me know! Grateful to be able to contribute to such an impactful project :)