GH-96079 Fix missing field name for _AnnotatedAlias #96080
Conversation
- Issue: Lib/typing.py Missing field _name for _AnnotatedAlias #96079
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
Can you add a test case showing what user-visible behavior you're changing here? |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
I've found a user-visible effect of the change.
Without this change, the __module__ attribute of an Annotated type is "builtins", which is incorrect. With this fix, it's "typing", correctly.
Main:
>>> import typing
>>> typing.Annotated[int, "foo"].__module__
'builtins'
>>>
Patched:
>>> typing.Annotated[int, "foo"].__module__
'typing'
>>>
Hopefully that can inspire a test?
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
| def __mro_entries__(self, bases): | ||
| return (self.__origin__,) |
There was a problem hiding this comment.
What happens without this? It seems kind of random to me (but I didn't try to run the tests).
There was a problem hiding this comment.
@gvanrossum First about __module__: it is not truly covered by test:
cpython/Lib/test/test_typing.py
Line 7133 in c7f2686
Here typing.Any.__module__ is typing, so passed, but errors in int. It is directly caused by:
Lines 1357 to 1358 in c7f2686
The idea of this PR is to add _name attribute to _AnnotatedAlias instance, since _AnnotatedAlias.__origin__ is just the first argument and nowhere to determind where Annotated annotation from.
But with _name attribute, _GenericAlias will think the __origin__ is generic ABCs, Generic will finally add to mros.
Lines 1270 to 1280 in c7f2686
So __mro_entries__ overridden is required.