-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-95914: Add paragraph about PEP 654 in main body of 'What's New in 3.11' #95937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
232d87b
gh-95914: add paragraph about pep 654 in main body of 'what's new in …
iritkatriel 6953eba
whitespace
iritkatriel 87d77c4
heading
iritkatriel e18ee3c
whitespace
iritkatriel 4b13c09
:keyword:
iritkatriel dd28613
revert PEP-678 changes. Update titles
iritkatriel c64a047
whitespace
iritkatriel 602fdc9
whitespace
iritkatriel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
heading
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
- Loading branch information
commit 87d77c4d35a530ce1fe31739288e03629078a6bd
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we be consistent about PEP numbers in Feature section titles? Right now the type hint PEP sections are in the form
PEP NNN: <Title>
, this section and the one below is in the form<Title> (PEP NNN)
, and the two above it don't mention the PEP number at all in the title.IMO, it would seem to make sense to either elide the PEP numbers in the New Features section titles (as I do for the section below in #95914 , since they don't add much value for most users and are already mentioned/linked in the section body and Summary), or consistently use them with the same format between these two sections (I can take care of the others in my separate PRs, but it would be nice to be consistent here).