8000 gh-95724: Clarify taskgroups.py license. by 1st1 · Pull Request #95847 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-95724: Clarify taskgroups.py license. #95847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2022
Merged

gh-95724: Clarify taskgroups.py license. #95847

merged 1 commit into from
Aug 11, 2022

Conversation

1st1
Copy link
Member
@1st1 1st1 commented Aug 10, 2022 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from gvanrossum August 10, 2022 05:07
@1st1 1st1 requested a review from asvetlov as a code owner August 10, 2022 05:07
gvanrossum
gvanrossum requested changes Aug 10, 2022
View reviewed changes
Copy link
Member
@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need the same for test_taskgroups.py

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@gvanrossum
Copy link
Member

@graingert Does this work for you?

@1st1
Copy link
Member Author
1st1 commented Aug 10, 2022

Need the same for test_taskgroups.py

Done.

@gvanrossum
Copy link
Member

LGTM but let's wait for @graingert (though not too long).

This was referenced Aug 10, 2022
Closed
Closed
graingert
graingert approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor
@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this is quite a bit more obvious

Maybe this is better?

# Adapted for use in CPython with permission from the EdgeDB project;
# license: PSFL

@gvanrossum
Copy link
Member

@1st1 -- what do you think of Thomas's alternative? If that pleases you, just make it so and we can put this to rest (a backport to 3.11 should be fine since it's just a comment). If not, let us know and we'll just land this as you have it now.

@1st1
Copy link
Member Author
1st1 commented Aug 11, 2022

I think my version is more broad, but IANAL, and I'm kinda surprised that Thomas is. ;)

At least to my knowledge (and I have a bit of experience with this) my version is better so I'll just merge this PR as is.

@1st1 1st1 merged commit 7da4937 into python:main Aug 11, 2022
@1st1 1st1 deleted the lic branch August 11, 2022 23:12
@gvanrossum gvanrossum added the needs backport to 3.11 only security fixes label Aug 11, 2022
@miss-islington
Copy link
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 11, 2022
@1st1 @miss-islington
pythongh-95724: Clarify taskgroups.py license. (pythonGH-95847)
94cb5d0 
(cherry picked from commit 7da4937)

Co-authored-by: Yury Selivanov <yury@edgedb.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 11, 2022
@bedevere-bot
Copy link

GH-95911 is a backport of this pull request to the 3.11 branch.

@graingert
Copy link
Contributor

I think my version is more broad, but IANAL, and I'm kinda surprised that Thomas is. ;)

At least to my knowledge (and I have a bit of experience with this) my version is better so I'll just merge this PR as is.

I'm certainly not a lawyer!

miss-islington added a commit that referenced this pull request Aug 11, 2022
@miss-islington @1st1
gh-95724: Clarify taskgroups.py license. (GH-95847)
24dd142 
(cherry picked from commit 7da4937)

Co-authored-by: Yury Selivanov <yury@edgedb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum requested changes

@graingert graingert graingert approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1st1 @bedevere-bot @gvanrossum @miss-islington @graingert
0