8000 gh-95605: Fix `float(s)` error message when `s` contains only whitespace by mdickinson · Pull Request #95665 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-95605: Fix float(s) error message when s contains only whitespace #95665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2022
Merged

gh-95605: Fix float(s) error message when s contains only whitespace #95665

merged 2 commits into from
Aug 10, 2022

Conversation

mdickinson
Copy link
Member
@mdickinson mdickinson commented Aug 4, 2022 •
edited by bedevere-bot
Loading

This PR fixes the error message from float(s) in the case where s contains only whitespace.

Closes #95605.

@mdickinson mdickinson mentioned this pull request Aug 4, 2022
Closed
@mdickinson mdickinson added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Aug 4, 2022
mdickinson
mdickinson commented Aug 4, 2022
View reviewed changes
mdickinson
mdickinson commented Aug 4, 2022
View reviewed changes
@mdickinson
Copy link
Member Author
mdickinson commented Aug 9, 2022 •
edited
Loading

@ericvsmith Would you have bandwidth for review, by any chance? I think it's a fairly simple fix. (Indeed, I was sorely tempted to try a more complicated refactoring and cleanup, but I think that's best left for 3.12.)

ericvsmith
ericvsmith approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member
@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me. Thanks, @mdickinson!

@mdickinson
Copy link
Member Author

Thanks, @ericvsmith!

@mdickinson mdickinson merged commit 97e9cfa into python:main Aug 10, 2022
@miss-islington
Copy link
Contributor

Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-95858 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 10, 2022
@bedevere-bot
Copy link

GH-95859 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2022
@mdickinson @miss-islington
pythongh-95605: Fix float(s) error message when s contains only w…
db20540 
…hitespace (pythonGH-95665)

This PR fixes the error message from float(s) in the case where s contains only whitespace.
(cherry picked from commit 97e9cfa)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2022
@mdickinson @miss-islington
pythongh-95605: Fix float(s) error message when s contains only w…
3a016e4 
…hitespace (pythonGH-95665)

This PR fixes the error message from float(s) in the case where s contains only whitespace.
(cherry picked from commit 97e9cfa)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
mdickinson added a commit that referenced this pull request Aug 10, 2022
@miss-islington @mdickinson
gh-95605: Fix float(s) error message when s contains only whitesp…
b4f968e 
…ace (GH-95665) (GH-95859)

This PR fixes the error message from float(s) in the case where s contains only whitespace.
(cherry picked from commit 97e9cfa)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
mdickinson added a commit that referenced this pull request Aug 11, 2022
@miss-islington @mdickinson
gh-95605: Fix float(s) error message when s contains only whitesp…
3ea9ba6 
…ace (GH-95665) (GH-95858)

This PR fixes the error message from float(s) in the case where s contains only whitespace.
(cherry picked from commit 97e9cfa)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The ValueError for converting an all-whitespace string to a float misleadingly displays it as the empty string
4 participants
@mdickinson @miss-islington @bedevere-bot @ericvsmith
0