python · philg314 · Jul 29, 2022 · Jul 29, 2022 · Aug 2, 2022 · Aug 2, 2022
diff --git a/Doc/whatsnew/3.12.rst b/Doc/whatsnew/3.12.rst
@@ -461,6 +461,8 @@ Porting to Python 3.12
   :py:meth:`~class.__subclasses__` (using :c:func:`PyObject_CallMethod`,
   for example).
 
+* Fixed wrong sign placement in ``PyUnicode_FromFormat``.
+  (Contributed by Philip Georgi in :gh:`95505`.)
 
 Deprecated
 ----------

diff --git a/Misc/ACKS b/Misc/ACKS
@@ -608,6 +608,7 @@ Marius Gedminas
 Jan-Philip Gehrcke
 Thomas Gellekum
 Gabriel Genellina
+Philip Georgi
 Christos Georgiou
 Elazar (אלעזר) Gershuni
 Ben Gertzfield

diff --git a/Misc/NEWS.d/next/C API/2022-07-31-21-58-27.gh-issue-95504.wy7B1F.rst b/Misc/NEWS.d/next/C API/2022-07-31-21-58-27.gh-issue-95504.wy7B1F.rst
@@ -0,0 +1,2 @@
+Fix sign placement when specifying width or precision in
+``PyUnicode_FromFormat``. Patch by Philip Georgi.
@@ -169,7 +169,7 @@
 @MODULE__XXTESTFUZZ_TRUE@_xxtestfuzz _xxtestfuzz/_xxtestfuzz.c _xxtestfuzz/fuzzer.c
 @MODULE__TESTBUFFER_TRUE@_testbuffer _testbuffer.c
 @MODULE__TESTINTERNALCAPI_TRUE@_testinternalcapi _testinternalcapi.c
-@MODULE__TESTCAPI_TRUE@_testcapi _testcapimodule.c _testcapi/vectorcall.c _testcapi/heaptype.c
+@MODULE__TESTCAPI_TRUE@_testcapi _testcapimodule.c _testcapi/vectorcall.c _testcapi/heaptype.c _testcapi/unicode.c
 
 # Some testing modules MUST be built as shared libraries.
 *shared*

diff --git a/Modules/_testcapi/parts.h b/Modules/_testcapi/parts.h
@@ -2,3 +2,4 @@
 
 int _PyTestCapi_Init_Vectorcall(PyObject *module);
 int _PyTestCapi_Init_Heaptype(PyObject *module);
+int _PyTestCapi_Init_Unicode(PyObject *module);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Fix sign placement when specifying width or precision in
		``PyUnicode_FromFormat``. Patch by Philip Georgi.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,3 +2,4 @@

		int _PyTestCapi_Init_Vectorcall(PyObject *module);
		int _PyTestCapi_Init_Heaptype(PyObject *module);
		int _PyTestCapi_Init_Unicode(PyObject *module);