-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-95389: socketmodule: expose popular ETHERTYPE_*
constants
#95390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a72f5cf
gh-95389: socketmodule: expose popular `ETH_P_*` constants
noamcohen97 764884c
added doc
noamcohen97 36844c7
📜🤖 Added by blurb_it.
blurb-it[bot] 6702add
sort constants alphabetically in doc
noamcohen97 7da1979
move definition
noamcohen97 18b0286
Update Misc/NEWS.d/next/Core and Builtins/2022-07-30-14-10-27.gh-issu…
noamcohen97 cbc8303
better documentation
noamcohen97 2eec634
added missing include
noamcohen97 7081b27
comment explaining consts choice
noamcohen97 886f908
support macOS and FreeBSD
noamcohen97 2a0accb
fix news entry
noamcohen97 8be938b
make doc clearer
noamcohen97 7fd3467
Update Doc/library/socket.rst
noamcohen97 257e46b
Apply suggestions from code review
noamcohen97 36b1d6a
added footnote
noamcohen97 43b5d45
Apply suggestions from code review
noamcohen97 fc9bc01
doc fix
noamcohen97 e74990c
Merge branch 'main' into raw-socket
noamcohen97
8000
Oct 23, 2022
e992521
Merge branch 'main' into raw-socket
noamcohen97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Core and Builtins/2022-07-30-14-10-27.gh-issue-95389.nSGEkG.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Expose :data:`~socket.ETH_P_ALL` and some of the | ||
:ref:`ETHERTYPE_* constants <socket-ethernet-types>` in :mod:`socket`. | ||
Patch by Noam Cohen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.