10000 gh-95174: Move WASIX logic into wasi-env (GH-95320) by tiran · Pull Request #95320 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-95174: Move WASIX logic into wasi-env (GH-95320) #95320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

gh-95174: Move WASIX logic into wasi-env (GH-95320) #95320

merged 1 commit into from
Jul 27, 2022

Conversation

tiran
Copy link
Member
@tiran tiran commented Jul 27, 2022 •
edited by bedevere-bot
Loading

wasi-env now sets WASIX flags. This allows us to control all build
parameter for wasm32-wasi buildbot from CPython repository.

Also export and improve SYSROOT parameter.

@tiran
pythongh-95174: Use WASIX logic into wasi-env
4a7724b 
wasi-env now sets WASIX flags. This allows us to control all build
parameter for wasm32-wasi buildbot from CPython repository.

Also export and improve SYSROOT parameter.
@tiran tiran added build The build process and cross-build needs backport to 3.11 only security fixes labels Jul 27, 2022
tiran added a commit to tiran/buildmaster-config that referenced this pull request Jul 27, 2022
@tiran
Use wasi-env script to set build parameters
7850c57 
Instead of hard-coding build flags in the build bot configuration,
wasm32-wasi buildbot now uses CPython's wasi-env script. This allows us
to control the build parameters from CPython.

Depends on python/cpython#95320 + backport to
3.11.
@tiran tiran mentioned this pull request Jul 27, 2022
Merged
@tiran tiran requested a review from brettcannon July 27, 2022 12:35
@tiran tiran changed the title gh-95174: Use WASIX logic into wasi-env gh-95174: Move WASIX logic into wasi-env Jul 27, 2022
@tiran tiran mentioned this pull request Jul 27, 2022
Merged
@tiran tiran changed the title gh-95174: Move WASIX logic into wasi-env gh-95174: Move WASIX logic into wasi-env (GH-95320) Jul 27, 2022
@tiran tiran merged commit 2833f37 into python:main Jul 27, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2833f3798dc3647e850b303a4d0fa00609a0ae9b 3.11

@tiran tiran deleted the gh-95174-wasi-env branch July 27, 2022 13:30
@tiran tiran added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jul 27, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2022
@tiran @miss-islington
pythongh-95174: Move WASIX logic into wasi-env (pythonGH-95320) 8000
4340188 
wasi-env now sets WASIX flags. This allows us to control all build
parameter for wasm32-wasi buildbot from CPython repository.

Also export and improve SYSROOT parameter.
(cherry picked from commit 2833f37)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 27, 2022
@bedevere-bot
Copy link

GH-95331 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Jul 27, 2022
@miss-islington @tiran
gh-95174: Move WASIX logic into wasi-env (GH-95320)
25086f1 
wasi-env now sets WASIX flags. This allows us to control all build
parameter for wasm32-wasi buildbot from CPython repository.

Also export and improve SYSROOT parameter.
(cherry picked from commit 2833f37)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

Assignees

@tiran tiran

Labels
build The build process and cross-build skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiran @miss-islington @bedevere-bot
0