8000 Statistics inv_cdf sync with corresponding random module normal distributions by rhettinger · Pull Request #95265 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Statistics inv_cdf sync with corresponding random module normal distributions #95265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 2 commits into from
Jul 26, 2022
Merged

Statistics inv_cdf sync with corresponding random module normal distributions #95265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baca805
Sync C code with Python equivalent
rhettinger Jul 19, 2022
9bca4fb
Let inv_cdf() support the case with a zero stdev
rhettinger Jul 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Lib/statistics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,8 +1221,6 @@ def inv_cdf(self, p):
"""
if p <= 0.0 or p >= 1.0:
raise StatisticsError('p must be in the range 0.0 < p < 1.0')
if self._sigma <= 0.0:
raise StatisticsError('cdf() not defined when sigma at or below zero')
return _normal_dist_inv_cdf(p, self._mu, self._sigma)

def quantiles(self, n=4):
Expand Down
7 changes: 4 additions & 3 deletions Lib/test/test_statistics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2801,9 +2801,10 @@ def test_inv_cdf(self):
iq.inv_cdf(1.0) # p is one
with self.assertRaises(self.module.StatisticsError):
iq.inv_cdf(1.1) # p over one
with self.assertRaises(self.module.StatisticsError):
iq = NormalDist(100, 0) # sigma is zero
iq.inv_cdf(0.5)

# Supported case:
iq = NormalDist(100, 0) # sigma is zero
self.assertEqual(iq.inv_cdf(0.5), 100)

# Special values
self.assertTrue(math.isnan(Z.inv_cdf(float('NaN'))))
Expand Down
2 changes: 1 addition & 1 deletion Modules/_statisticsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ _statistics__normal_dist_inv_cdf_impl(PyObject *module, double p, double mu,
/*[clinic end generated code: output=02fd19ddaab36602 input=24715a74be15296a]*/
{
double q, num, den, r, x;
if (p <= 0.0 || p >= 1.0 || sigma <= 0.0) {
if (p <= 0.0 || p >= 1.0) {
goto error;
}

Expand Down
0