gh-95051: ensure that timeouts scheduled with `asyncio.Timeout` that have already expired are deliverered promptly #95109

graingert · 2022-07-21T22:52:13Z

Issue: asyncio.timeout(0) and asyncio.timeout(-1) cancellation is delayed #95051

Lib/test/test_asyncio/test_timeouts.py

Lib/asyncio/timeouts.py

Misc/NEWS.d/next/Library/2022-07-21-22-59-22.gh-issue-95109.usxA9r.rst

…xA9r.rst

Lib/test/test_asyncio/test_timeouts.py

Misc/NEWS.d/next/Library/2022-07-21-22-59-22.gh-issue-95109.usxA9r.rst

…xA9r.rst Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

gvanrossum

LG, just a nit, and maybe now that we're testing this behavior, it should be noted in the docs?

Lib/asyncio/timeouts.py

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>

miss-islington · 2022-07-24T20:18:07Z

Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington · 2022-07-24T20:18:10Z

Sorry @graingert and @gvanrossum, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0c6f898005099be189ee65bcfda659f5fc13b802 3.11

gvanrossum · 2022-07-24T20:18:39Z

@graingert please backport manually and ask Pablo for a review.

miss-islington · 2022-07-24T20:20:07Z

Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot · 2022-07-24T20:20:14Z

GH-95216 is a backport of this pull request to the 3.11 branch.

AlexWaygood · 2022-07-24T20:21:27Z

@graingert please backport manually and ask Pablo for a review.

When @miss-islington's message is "I had trouble checking out the 3.X branch" (as opposed to "I couldn't create the backport due to a merge conflict"), just removing and re-adding the label is usually enough to fix it :)

miss-islington · 2022-07-24T20:22:13Z

Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

… that have already expired are deliverered promptly (pythonGH-95109) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> (cherry picked from commit 0c6f898) Co-authored-by: Thomas Grainger <tagrain@gmail.com>

AlexWaygood · 2022-07-24T20:23:46Z

GH-95216 is a backport of this pull request to the 3.11 branch.

@graingert, I already removed and re-added the label — this is the backport here

graingert · 2022-07-24T20:24:49Z

argh I saw the email notification and had a stale copy of the PR page open

AlexWaygood · 2022-07-24T20:26:06Z

argh I saw the email notification and had a stale copy of the PR page open

It's race conditions all the way down

gvanrossum · 2022-07-24T20:26:22Z

Maybe one of you can make the bot more user friendly?

graingert · 2022-07-24T20:26:24Z

It's race conditions all the way down

AlexWaygood · 2022-07-24T20:29:28Z

Maybe one of you can make the bot more user friendly?

It's been on my to-do list for a while.....

…have already expired are deliverered promptly (GH-95109) (GH-95216) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> (cherry picked from commit 0c6f898) Co-authored-by: Thomas Grainger <tagrain@gmail.com>

bedevere-bot added the awaiting review label Jul 21, 2022

graingert commented Jul 21, 2022

View reviewed changes

Lib/test/test_asyncio/test_timeouts.py Outdated Show resolved Hide resolved

graingert commented Jul 21, 2022

View reviewed changes

Lib/test/test_asyncio/test_timeouts.py Outdated Show resolved Hide resolved

graingert commented Jul 21, 2022

View reviewed changes

Lib/test/test_asyncio/test_timeouts.py Outdated Show resolved Hide resolved

graingert and others added 2 commits July 22, 2022 00:06

pythongh-95051: handle timeouts.timeout(0) and timeouts.timeout(-1)

dce6d74

📜🤖 Added by blurb_it.

51686d7

graingert force-pushed the asyncio-timeout-0-0 branch from c6281b2 to 51686d7 Compare July 21, 2022 23:06

graingert changed the title ~~gh-95051: handle timeouts.timeout(0) and timeouts.timeout(-1)~~ gh-95051: ensure that timeouts scheduled in the past with asyncio.Timeout are deliverered promptly Jul 21, 2022

graingert commented Jul 21, 2022

View reviewed changes

Lib/asyncio/timeouts.py Outdated Show resolved Hide resolved

Update Lib/asyncio/timeouts.py

418a81f

graingert changed the title ~~gh-95051: ensure that timeouts scheduled in the past with asyncio.Timeout are deliverered promptly~~ gh-95051: ensure that timeouts scheduled with asyncio.Timeout that have already expired are deliverered promptly Jul 21, 2022

graingert commented Jul 21, 2022

View reviewed changes

Misc/NEWS.d/next/Library/2022-07-21-22-59-22.gh-issue-95109.usxA9r.rst Outdated Show resolved Hide resolved

Update Misc/NEWS.d/next/Library/2022-07-21-22-59-22.gh-issue-95109.us…

174a3ff

…xA9r.rst

graingert added the needs backport to 3.11 only security fixes label Jul 21, 2022

graingert commented Jul 21, 2022

View reviewed changes

Lib/test/test_asyncio/test_timeouts.py Outdated Show resolved Hide resolved

graingert added 2 commits July 22, 2022 00:40

Update Lib/test/test_asyncio/test_timeouts.py

a42e1e1

Merge branch 'main' into asyncio-timeout-0-0

de2f046

graingert marked this pull request as ready for review July 22, 2022 09:42

graingert requested review from 1st1 and asvetlov as code owners July 22, 2022 09:42

kumaraditya303 assigned gvanrossum Jul 22, 2022

kumaraditya303 reviewed Jul 22, 2022

View reviewed changes

Misc/NEWS.d/next/Library/2022-07-21-22-59-22.gh-issue-95109.usxA9r.rst Outdated Show resolved Hide resolved

Update Misc/NEWS.d/next/Library/2022-07-21-22-59-22.gh-issue-95109.us…

495cd2b

…xA9r.rst Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

gvanrossum reviewed Jul 22, 2022

View reviewed changes

Lib/asyncio/timeouts.py Outdated Show resolved Hide resolved

graingert and others added 2 commits July 23, 2022 00:59

Update Lib/asyncio/timeouts.py

6b01baa

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>

document asyncio.timeout(-1)

b7fe485

graingert requested a review from gvanrossum July 23, 2022 00:53

gvanrossum approved these changes Jul 24, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Jul 24, 2022

gvanrossum merged commit 0c6f898 into python:main Jul 24, 2022

bedevere-bot removed the awaiting merge label Jul 24, 2022

graingert deleted the asyncio-timeout-0-0 branch July 24, 2022 20:18

AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jul 24, 2022

bedevere-bot 8000 removed the needs backport to 3.11 only security fixes label Jul 24, 2022

graingert added the needs backport to 3.11 only security fixes label Jul 24, 2022

AlexWaygood removed the needs backport to 3.11 only security fixes label Jul 24, 2022

kumaraditya303 mentioned this pull request Oct 2, 2022

asyncio.timeout(0) and asyncio.timeout(-1) cancellation is delayed #95051

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-95051: ensure that timeouts scheduled with `asyncio.Timeout` that have already expired are deliverered promptly #95109

gh-95051: ensure that timeouts scheduled with `asyncio.Timeout` that have already expired are deliverered promptly #95109

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gh-95051: ensure that timeouts scheduled with asyncio.Timeout that have already expired are deliverered promptly #95109

gh-95051: ensure that timeouts scheduled with asyncio.Timeout that have already expired are deliverered promptly #95109

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gh-95051: ensure that timeouts scheduled with `asyncio.Timeout` that have already expired are deliverered promptly #95109

gh-95051: ensure that timeouts scheduled with `asyncio.Timeout` that have already expired are deliverered promptly #95109