8000 [3.10] gh-95095: Use SSL_CTX_get_max_proto_version instead of SSL_CTX_ctrl (GH-95096) by miss-islington · Pull Request #95102 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.10] gh-95095: Use SSL_CTX_get_max_proto_version instead of SSL_CTX_ctrl (GH-95096) #95102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

[3.10] gh-95095: Use SSL_CTX_get_max_proto_version instead of SSL_CTX_ctrl (GH-95096) #95102

merged 1 commit into from
Jul 21, 2022

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Jul 21, 2022 •
edited by bedevere-bot
Loading

The wrapper macros are more readable and match the form recommended in
the OpenSSL documentation. They also slightly less error-prone, as the
mapping of arguments to SSL_CTX_ctrl is not always clear. (Though in
this case it's straightforward.)
https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_get_max_proto_version.html
(cherry picked from commit 936f71e)

Co-authored-by: David Benjamin davidben@davidben.net

@davidben @miss-islington
pythongh-95095: Use SSL_CTX_get_max_proto_version instead of SSL_CTX_…
265ef18 
…ctrl (pythonGH-95096)

The wrapper macros are more readable and match the form recommended in
the OpenSSL documentation. They also slightly less error-prone, as the
mapping of arguments to SSL_CTX_ctrl is not always clear. (Though in
this case it's straightforward.)
https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_get_max_proto_version.html
(cherry picked from commit 936f71e)

Co-authored-by: David Benjamin <davidben@davidben.net>
@miss-islington miss-islington requested a review from tiran as a code owner July 21, 2022 18:44
@ghost
Copy link
ghost commented Jul 21, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@miss-islington
Copy link
Contributor Author

@davidben: Status check is done, and it's a failure ❌ .

@bedevere-bot bedevere-bot mentioned this pull request Jul 21, 2022
Merged
@miss-islington
Copy link
Contributor Author

@davidben: Status check is done, and it's a failure ❌ .

@davidben
Copy link
Contributor

I see something got confused by multiple emails. :-)

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8fd2d36 into python:3.10 Jul 21, 2022
@miss-islington miss-islington deleted the backport-936f71e-3.10 branch July 21, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @davidben @tiran @bedevere-bot
0