[3.11] gh-95095: Use SSL_CTX_get_max_proto_version instead of SSL_CTX_ctrl (GH-95096) #95101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctrl (pythonGH-95096) The wrapper macros are more readable and match the form recommended in the OpenSSL documentation. They also slightly less error-prone, as the mapping of arguments to SSL_CTX_ctrl is not always clear. (Though in this case it's straightforward.) https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_get_max_proto_version.html (cherry picked from commit 936f71e) Co-authored-by: David Benjamin <davidben@davidben.net>
|
All commit authors signed the Contributor License Agreement. |
|
@davidben: Status check is done, and it's a failure ❌ . |
|
@davidben: Status check is done, and it's a failure ❌ . |
2 similar comments
|
@davidben: Status check is done, and it's a failure ❌ . |
|
@davidben: Status check is done, and it's a failure ❌ . |
|
@davidben For some reasons the automatic backport has a different email address than your initial commit. I'm not entire sure what is going on here... |
|
Not sure either. Seems like a bug but probably not worth fussing over. Pressed more buttons. Hopefully it's happy now? |
|
CLA bot is a happy bot now. Thanks :) |
|
Status check is done, and it's a success ✅ . |
tiran
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapper macros are more readable and match the form recommended in
the OpenSSL documentation. They also slightly less error-prone, as the
mapping of arguments to SSL_CTX_ctrl is not always clear. (Though in
this case it's straightforward.)
https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_get_max_proto_version.html
(cherry picked from commit 936f71e)
Co-authored-by: David Benjamin davidben@davidben.net