8000 [3.7] bpo-34421: Improve distutils logging for non-ASCII strings. (GH-9126) by serhiy-storchaka · Pull Request #9506 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.7] bpo-34421: Improve distutils logging for non-ASCII strings. (GH-9126) #9506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2018
Merged

[3.7] bpo-34421: Improve distutils logging for non-ASCII strings. (GH-9126) #9506

merged 2 commits into from
Sep 23, 2018

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Sep 23, 2018 •
edited by bedevere-bot
Loading

Use "backslashreplace" instead of "unicode-escape". It is not
implementation depended and escapes only non-encodable characters.

Also simplify the code.
(cherry picked from commit 4b860fd)

https://bugs.python.org/issue34421

@serhiy-storchaka
[3.7] bpo-34421: Improve distutils logging for non-ASCII strings. (py…
dda2e68 
…thonGH-9126)

Use "backslashreplace" instead of "unicode-escape".  It is not
implementation depended and escapes only non-encodable characters.

Also simplify the code.
(cherry picked from commit 4b860fd)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka
Use in-memory stream instead of NamedTemporaryFile.
8a96122
@bedevere-bot bedevere-bot added skip news type-bug An unexpected behavior, bug, or error labels Sep 23, 2018
@serhiy-storchaka serhiy-storchaka merged commit c73df53 into python:3.7 Sep 23, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the backport-4b860fd-3.7 branch September 23, 2018 07:31
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 23, 2018
@serhiy-storchaka @miss-islington
bpo-34421: Improve distutils logging for non-ASCII strings. (pythonGH…
7607547 
…-9126) (pythonGH-9506)

Use "backslashreplace" instead of "unicode-escape".  It is not
implementation depended and escapes only non-encodable characters.

Also simplify the code.
(cherry picked from commit 4b860fd)
(cherry picked from commit c73df53)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-9510 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Sep 23, 2018
@miss-islington @serhiy-storchaka
bpo-34421: Improve distutils logging for non-ASCII strings. (GH-9126) (…
0b67995 
…GH-9506)

Use "backslashreplace" instead of "unicode-escape".  It is not
implementation depended and escapes only non-encodable characters.

Also simplify the code.
(cherry picked from commit 4b860fd)
(cherry picked from commit c73df53)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni
0