8000 gh-77617: Add interactive shell for sqlite3 by erlend-aasland · Pull Request #95026 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-77617: Add interactive shell for sqlite3 #95026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Aug 1, 2022
Merged

gh-77617: Add interactive shell for sqlite3 #95026

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
def2e81
Add proof-of-concept REPL
May 28, 2020
1f01905
Add NEWS
erlend-aasland Jul 19, 2022
86a4566
Remove redundant __name__ condition
erlend-aasland Jul 20, 2022
d04b6f3
Merge branch 'main' into sqlite-shell
erlend-aasland Jul 20, 2022
896834c
Add -v argument for dumping SQLite version
erlend-aasland Jul 20, 2022
4ba731a
Address review: close connection explicitly
erlend-aasland Jul 20, 2022
814cced
Merge branch 'main' into sqlite-shell
erlend-aasland Jul 29, 2022
8179a68
Add docs
erlend-aasland Jul 29, 2022
91a77b7
Remove copyright, credits, and license cli commands
erlend-aasland Jul 29, 2022
2f27a04
Document how to quit
erlend-aasland Jul 29, 2022
ae55e8e
Fix sphinx option refs by moving the footnote up to where it belongs,…
erlend-aasland Jul 29, 2022
91e1ec9
Merge branch 'main' into sqlite-shell
erlend-aasland Jul 29, 2022
024cd90
Address review: iterate over cursor
Jul 29, 2022
dee441a
Address review: repr iso. f-string
Jul 29, 2022
ec04ea3
Address review: pass connection iso. path
erlend-aasland Jul 29, 2022
9b79230
Address review: use argparse version trick
erlend-aasland Jul 29, 2022
74fb53d
Address review: use . prefix for commands, and sys.exit for quitting
erlend-aasland Jul 29, 2022
1d62ccb
Address review: reduce indent level
erlend-aasland Jul 29, 2022
340b896
Add filename and sql args a la sqlite3 cli
erlend-aasland Jul 30, 2022
d906361
Fix constructor
erlend-aasland Jul 30, 2022
43c535c
Sync with main
erlend-aasland Jul 31, 2022
e728e17
Address Serhiy's second round of review
erlend-aasland Jul 31, 2022
e2e24b8
Remove useless function and lambda params
erlend-aasland Jul 31, 2022
294acb9
Move CLI docs to Reference
erlend-aasland Jul 31, 2022
3cfff7f
Improve NEWS and add What's New
erlend-aasland Jul 31, 2022
82c753c
Partially address Kumar's review: use narrow exception
erlend-aasland Jul 31, 2022
36454ab
Partially address more of Kumar's review: add guard
erlend-aasland Jul 31, 2022
625e2e3
Use pattern matching
erlend-aasland Jul 31, 2022
f624873
Revert "Partially address more of Kumar's review: add guard"
erlend-aasland Jul 31, 2022
df75f5f
Print errors to stderr iso. stdout
erlend-aasland Jul 31, 2022
44c2571
Non-zero exit for SQL errors passed from command line
erlend-aasland Jul 31, 2022
d640458
Add tests
erlend-aasland Jul 31, 2022
0997004
Simplify interactive tests
erlend-aasland Jul 31, 2022
7ba91e7
Use -Xutf8
erlend-aasland Jul 31, 2022
b74e010
Fix argument order
erlend-aasland Jul 31, 2022
903b867
Address review: move cleanups up
erlend-aasland Aug 1, 2022
796ba16
Last adjustment: inline runsql()
erlend-aasland Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review: repr iso. f-string 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
  • Loading branch information
@serhiy-storchaka
Erlend Egeberg Aasland and serhiy-storchaka authored Jul 29, 2022
commit dee441a7b16e01eee1f5227fcd8b6c35cad92a45
2 changes: 1 addition & 1 deletion Lib/sqlite3/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def main():
if args.database == ":memory:":
db_name = "a transient in-memory database"
else:
db_name = f"'{args.database}'"
db_name = repr(args.database)

banner = dedent(f"""
sqlite3 shell, running on SQLite version {sqlite3.sqlite_version}
Expand Down
0