8000 bpo-26947: DOC: clarify wording on hashable in glossary by csabella · Pull Request #948 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-26947: DOC: clarify wording on hashable in glossary #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2017
Merged

bpo-26947: DOC: clarify wording on hashable in glossary #948

merged 1 commit into from
Apr 2, 2017

Conversation

csabella
Copy link
Contributor
@csabella csabella commented Apr 1, 2017

No description provided.

@mention-bot
Copy link
mention-bot 8000 commented Apr 1, 2017

@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @benjaminp and @tiran to be potential reviewers.

@zhangyangyu zhangyangyu added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Apr 1, 2017
@zhangyangyu zhangyangyu requested a review from vadmium April 1, 2017 14:35
vadmium
vadmium reviewed Apr 1, 2017
View reviewed changes
Copy link
Member
@vadmium vadmium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this improves the wording (to a native English speaker)

@orsenthil
Copy link
Member

I am +1 too.
8000

@orsenthil orsenthil merged commit 64c887a into python:master Apr 2, 2017
orsenthil added a commit that referenced this pull request Apr 2, 2017
@orsenthil
bpo-26947: DOC: clarify wording on hashable in glossary (#948) (#957)
a71a3ad 
(cherry picked from commit 64c887a)
orsenthil added a commit that referenced this pull request Apr 2, 2017
@orsenthil
bpo-26947: DOC: clarify wording on hashable in glossary (#948) (#958)
51fc7e3 
(cherry picked from commit 64c887a)
@csabella csabella deleted the bpo26947 branch April 2, 2017 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmium vadmium vadmium left review comments

Assignees
No one assigned
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@csabella @mention-bot @orsenthil @vadmium @zhangyangyu @Mariatta @the-knights-who-say-ni
0