8000 gh-93939: Add script to check extension modules by tiran · Pull Request #94545 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-93939: Add script to check extension modules #94545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 5, 2022
Merged

gh-93939: Add script to check extension modules #94545

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0293bbd
gh-93939: Add script to check extension modules
tiran Jul 3, 2022
ab9e52b
Improve doc string, rename checker script
tiran Jul 4, 2022
1116e98
Fix typo
tiran Jul 4, 2022
bcaf25c
Use raw strings for regular expressions.
tiran Jul 4, 2022
a1d5e5e
Update Tools/scripts/check_extension_modules.py
tiran Jul 4, 2022
06b014b
remove debug print
tiran Jul 4, 2022
8a7a468
Better error reporting
tiran Jul 4, 2022
4a3e729
Apply suggestions from code review
tiran Jul 5, 2022
c3d2c8f
Remove auto import
tiran Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better error reporting
  • Loading branch information
@tiran
tiran committed Jul 4, 2022
commit 8a7a468de73fb2140fe2ccb923400667c702f5fa
8 changes: 6 additions & 2 deletions Tools/scripts/check_extension_modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,12 @@ def list_module_names(self, *, all: bool = False) -> set:
return names

def get_builddir(self) -> pathlib.Path:
with open(self.pybuilddir_txt, encoding="utf-8") as f:
builddir = f.read()
try:
with open(self.pybuilddir_txt, encoding="utf-8") as f:
builddir = f.read()
except FileNotFoundError:
logger.error("%s must be run from the top build directory", __file__)
raise
builddir = pathlib.Path(builddir)
logger.debug("%s: %s", self.pybuilddir_txt, builddir)
return builddir
Expand Down
0