8000 gh-91330: Tests and docs for dataclass descriptor-typed fields by debonte · Pull Request #94424 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-91330: Tests and docs for dataclass descriptor-typed fields #94424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 5, 2022
Merged

gh-91330: Tests and docs for dataclass descriptor-typed fields #94424

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
db3eef7
First cut at unit tests
debonte Mar 30, 2022
8b4689f
Fix comment typo
debonte Jun 27, 2022
1ea97fa
Add tests for uninitialized field and default value
debonte Jun 28, 2022
409614c
Add test for __get__ raising AttributeError, no default val
debonte Jun 29, 2022
ad246ba
First cut at docs
debonte Jun 29, 2022
e2e66f9
Apply suggestions from ambv
debonte Jun 29, 2022
5a92149
Remove None check in __set__
debonte Jun 29, 2022
6432ee3
Use __set_name__ instead of hardcoded name
debonte Jun 29, 2022
6e19aef
Attempt at more realistic example
debonte Jun 29, 2022
ad9f6f4
Add Blurb
ambv Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for uninitialized field and default value
  • Loading branch information
@debonte
debonte committed Jun 28, 2022
commit 1ea97fab603cd439f36ae6bd683128ef51e4c984
41 changes: 41 additions & 0 deletions Lib/test/test_dataclasses.py
C64A
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3279,6 +3279,47 @@ class C:
c.i = 10
self.assertEqual(D.__set__.call_count, 1)

def test_setting_uninitialized_descriptor_field(self):
class D:
pass

D.__set__ = Mock()

@dataclass
class C:
i: D

# D.__set__ is not called because there's no D instance to call it on
D.__set__.reset_mock()
c = C(5)
self.assertEqual(D.__set__.call_count, 0)

# D.__set__ still isn't called after setting i to an instance of D
# because descriptors don't behave like that when stored as instance vars
c.i = D()
c.i = 5
self.assertEqual(D.__set__.call_count, 0)

def test_default_value(self):
class D:
def __get__(self, instance: Any, owner: object) -> int:
if instance is None:
return 100
return instance._x

def __set__(self, instance: Any, value: int) -> None:
instance._x = value

@dataclass
class C:
i: D = D()

c = C()
self.assertEqual(c.i, 100)

c = C(5)
self.assertEqual(c.i, 5)

class TestStringAnnotations(unittest.TestCase):
def test_classvar(self):
# Some expressions recognized as ClassVar really aren't. But
Expand Down
0