Fix pickletools doc for NEWFALSE #9432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
287b0f9 to
2da1c82
Compare
serhiy-storchaka
approved these changes
Sep 20, 2018
|
But for consistency with other similar opcodes, I think it is better to remove the first line and left just |
|
Sure, let me change that. |
serhiy-storchaka
approved these changes
Sep 22, 2018
|
Thanks @krzysieq for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
|
GH-9494 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 22, 2018
Also make docs for NEWFALSE and NEWTRUE more consistent with docs for other opcodes. (cherry picked from commit 488cfb7) Co-authored-by: Krzysztof Wroblewski <krzysiek.wr@gmail.com>
|
GH-9495 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 22, 2018
Also make docs for NEWFALSE and NEWTRUE more consistent with docs for other opcodes. (cherry picked from commit 488cfb7) Co-authored-by: Krzysztof Wroblewski <krzysiek.wr@gmail.com>
|
GH-9496 is a backport of this pull request to the 2.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 22, 2018
Also make docs for NEWFALSE and NEWTRUE more consistent with docs for other opcodes. (cherry picked from commit 488cfb7) Co-authored-by: Krzysztof Wroblewski <krzysiek.wr@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 22, 2018
Also make docs for NEWFALSE and NEWTRUE more consistent with docs for other opcodes. (cherry picked from commit 488cfb7) Co-authored-by: Krzysztof Wroblewski <krzysiek.wr@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 22, 2018
Also make docs for NEWFALSE and NEWTRUE more consistent with docs for other opcodes. (cherry picked from commit 488cfb7) Co-authored-by: Krzysztof Wroblewski <krzysiek.wr@gmail.com>
|
Thanks @krzysieq for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-9584 is a backport of this pull request to the 3.7 branch. |
BC31
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2018
Also make docs for NEWFALSE and NEWTRUE more consistent with docs for other opcodes. (cherry picked from commit 488cfb7) Co-authored-by: Krzysztof Wroblewski <krzysiek.wr@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 26, 2018
Also make docs for NEWFALSE and NEWTRUE more consistent with docs for other opcodes. (cherry picked from commit 488cfb7) Co-authored-by: Krzysztof Wroblewski <krzysiek.wr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the doc for the
NEWFALSEopcode inpickletools.Note that this first part of a doc is shown when
pickletoolsis used with--annotate.