8000 gh-69714: Make `calendar` module fully tested by bxsx · Pull Request #93655 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content
8000

gh-69714: Make calendar module fully tested #93655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jul 22, 2023
Merged

gh-69714: Make calendar module fully tested #93655

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
cb0523e
Increased test coverage of calendar module
rohitmediratta Nov 1, 2015
78935da
gh-69714: Restore the test thrown out by cb0523e67c
bxsx Jun 6, 2022
0dd6321
gh-69714: Increase test coverage for `calendar.Locale{Text|HTML}Calen…
bxsx Jun 6, 2022
69c8f4f
gh-69714: Add missing test cases for custom locale in `calendar.Local…
bxsx Jun 7, 2022
a96786c
gh-69714: Remove unreachable code (and increase test coverage)
bxsx Jun 7, 2022
636b4e1
gh-69714: Increase CLI tests coverage
bxsx Jun 9, 2022
238c527
gh-69714: Add more test cases to `calendar` cmdline
bxsx Jun 9, 2022
b850c92
gh-69714: Increase test coverage for `calendar` cmdline
bxsx Jun 9, 2022
ab069a4
gh-57539: Add tests for `LocaleTextCalendar.formatweekday`
jesstess Apr 27, 2014
f1febfc
gh-69714: Increase test coverage for `LocaleTextCalendar.formatmonthn…
bxsx Jun 9, 2022
e9e8825
Merge branch 'main' into gh-69714/calendar-test-coverage
bxsx Jun 9, 2022
827e664
Remove comment
bxsx Jun 9, 2022
d28e2e4
gh-69714: Reorder locale in the test case
bxsx Jun 9, 2022
bbdc393
gh-69714: Extract test case
bxsx Jun 9, 2022
8914cdc
Update ACKS
bxsx Jun 9, 2022
68adf69
Add NEWS entry
bxsx Jun 9, 2022
40e0da3
Revert "gh-69714: Remove unreachable code (and increase test coverage)"
bxsx Jun 9, 2022
2b6f1f9
Expand the try clause to calls to `LocaleTextCalendar.formatmonthname…
bxsx Jun 9, 2022
64cb029
Revert "Revert "gh-69714: Remove unreachable code (and increase test …
bxsx Jun 9, 2022
2b2c8ef
Add missing whitespace
bxsx Jun 10, 2022
8b7bc06
gh-69714: Move the validation to the beginning of the function
bxsx Jun 11, 2022 8000
de21a51
gh-69714: Increase test coverage for illegal arguments
bxsx Jun 11, 2022
ab5a508
Revert "gh-69714: Add more test cases to `calendar` cmdline"
bxsx Jun 11, 2022
1558845
Clean up redundant arguments
bxsx Jun 11, 2022
0aa0caf
gh-69417: Include cases with odd widths in `formatmonthname`
bxsx Jun 11, 2022
e73fc9e
gh-69714: Split tests for LocaleTextCalendar and LocaleHTMLCalendar
bxsx Jun 11, 2022
5b094ae
Merge branch 'main' into gh-69714/calendar-test-coverage
iritkatriel Feb 18, 2023
87feac0
Merge branch 'main' into gh-69714/calendar-test-coverage
bxsx Jul 20, 2023
81d09b2
Merge branch 'main' into gh-69714/calendar-test-coverage
bxsx Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Expand the try clause to calls to `LocaleTextCalendar.formatmonthname… 
…()`.

This method temporarily changes the current locale to the given locale,
so `_locale.setlocale()` may raise `local.Error`.
  • Loading branch information
@bxsx
bxsx committed Jun 9, 2022
commit 2b6f1f9b2d8cf8d2c2054a7d69b95f04efa2cbd0
12 changes: 6 additions & 6 deletions Lib/test/test_calendar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,14 +644,14 @@ def test_locale_calendar_formatmonthname(self):
try:
# formatmonthname uses the same month names regardless of the width argument.
cal = calendar.LocaleTextCalendar(locale='en_US')
# For too short widths, a full name (with year) is used.
self.assertEqual(cal.formatmonthname(2022, 6, 2, withyear=False), "June")
self.assertEqual(cal.formatmonthname(2022, 6, 2, withyear=True), "June 2022")
# For long widths, a centered name is used.
self.assertEqual(cal.formatmonthname(2022, 6, 10, withyear=False), " June ")
self.assertEqual(cal.formatmonthname(2022, 6, 15, withyear=True), " June 2022 ")
except locale.Error:
raise unittest.SkipTest('cannot set the en_US locale')
# For too short widths, a full name (with year) is used.
self.assertEqual(cal.formatmonthname(2022, 6, 2, withyear=False), "June")
self.assertEqual(cal.formatmonthname(2022, 6, 2, withyear=True), "June 2022")
# For long widths, a centered name is used.
self.assertEqual(cal.formatmonthname(2022, 6, 10, withyear=False), " June ")
self.assertEqual(cal.formatmonthname(2022, 6, 15, withyear=True), " June 2022 ")

def test_locale_html_calendar_custom_css_class_month_name(self):
try:
Expand Down
0