8000 gh-93461: Invalidate sys.path_importer_cache entries with relative paths by tiran · Pull Request #93653 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-93461: Invalidate sys.path_importer_cache entries with relative paths #93653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2022
Merged

gh-93461: Invalidate sys.path_importer_cache entries with relative paths #93653

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
983288b
gh-93461: Invalidate sys.path_importer_cache entries with relative paths
tiran Jun 9, 2022
98f63aa
Fix and add test cases
tiran Jun 9, 2022
41aeca2
Use abspath for Windows
tiran Jun 10, 2022
5163c35
Don't include trailing '/.' to FileFinder path
tiran Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-93461: Invalidate sys.path_importer_cache entries with relative paths
  • Loading branch information
@tiran
tiran committed Jun 9, 2022
commit 983288bdfb0aa6f4f0cc81d4bf9d5b726e2e5a61
4 changes: 3 additions & 1 deletion Lib/importlib/_bootstrap_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,7 +1399,9 @@ def invalidate_caches():
"""Call the invalidate_caches() method on all path entry finders
stored in sys.path_importer_caches (where implemented)."""
for name, finder in list(sys.path_importer_cache.items()):
if finder is None:
# Drop entry if finder name is a relative path. The current
# working directory may have changed.
if finder is None or not _path_isabs(name):
del sys.path_importer_cache[name]
elif hasattr(finder, 'invalidate_caches'):
finder.invalidate_caches()
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-06-09-19-19-02.gh-issue-93461.5DqP1e.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
:func:`importlib.invalidate_caches` now drops entries from
:data:`sys.path_importer_cache` with a relative path as name. This solves a
caching issue when a process changes its current working directory.
0