8000 gh-93143: Avoid NULL check in LOAD_FAST based on analysis in the compiler by sweeneyde · Pull Request #93144 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-93143: Avoid NULL check in LOAD_FAST based on analysis in the compiler #93144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
May 31, 2022
Merged

gh-93143: Avoid NULL check in LOAD_FAST based on analysis in the compiler #93144

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
3627bb5
implement LOAD_FAST_KNOWN
sweeneyde May 10, 2022
ac0ad1b
fix leak and add stack effect
sweeneyde May 10, 2022
721e6ed
add failing test
sweeneyde May 10, 2022
42ef42f
Attempt exception handling
sweeneyde May 10, 2022
a8e94f8
Parameters are guaranteed to be initialized
sweeneyde May 10, 2022
038a85d
revert to LOAD_FAST on lineno setter and LocalsToFast
sweeneyde May 10, 2022
3243981
Port over superinstructions
sweeneyde May 10, 2022
0ddc721
remove debugging code so non-debug builds work.
sweeneyde May 10, 2022
35d2c51
merge with main
sweeneyde May 23, 2022
9c74fe5
Rename to LOAD_FAST_CHECK
sweeneyde May 23, 2022
b7c689b
revert debugging code
sweeneyde May 23, 2022
2c58c67
Add test cases
sweeneyde May 23, 2022
8f58dd6
Fix test_dis
sweeneyde May 23, 2022
f32c419
switch the opcode numbers back
sweeneyde May 23, 2022
1f14713
📜🤖 Added by blurb_it.
blurb-it[bot] May 23, 2022
f224e20
Don't access last instruction of empty basicblocks
sweeneyde May 23, 2022
5480a12
Merge branch 'known' of https://github.com/sweeneyde/cpython into known
sweeneyde May 23, 2022
b9da528
don't accidentally export symbols
sweeneyde May 23, 2022
2b15f1c
add description to magic number bump, only bump by 1
sweeneyde May 24, 2022
6feb63c
typo
sweeneyde May 24, 2022
90de166
merge with main
sweeneyde May 27, 2022
8000
75ae65d
use 'instr' var again
sweeneyde May 27, 2022
70e1ba8
rename, combine switch cases
sweeneyde May 29, 2022
a1d8b01
simplify the is-a-parameter logic
sweeneyde May 29, 2022
d193540
assert no extended args
sweeneyde May 29, 2022
8aa1132
assert no superinstructions
sweeneyde May 29, 2022
138eeaf
Mark unsafe except blocks of every instruction (with any oparg)
sweeneyde May 30, 2022
202e1e7
Only add checks when deleting, not modifying, locals
sweeneyde May 30, 2022
d569c5f
Merge remote-tracking branch 'upstream/main' into known
sweeneyde May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typo
  • Loading branch information
@sweeneyde
sweeneyde committed May 24, 2022
commit 6feb63cd3f2e8ba1146f0216bcc0e986ba0c3d03
2 changes: 1 addition & 1 deletion Lib/importlib/_bootstrap_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ def _write_atomic(path, data, mode=0o666):

# Python 3.12a1 3500 (Remove PRECALL opcode)
# Python 3.12a1 3501 (YIELD_VALUE oparg == stack_depth)
# Python 3.12a1 3502 (LOAD_FAST_KNOWN, no NULL-check in LOAD_FAST)
# Python 3.12a1 3502 (LOAD_FAST_CHECK, no NULL-check in LOAD_FAST)

# Python 3.13 will start with 3550

Expand Down
0