8000 gh-93019: Fix markup in zipfile.rst by hauntsaninja · Pull Request #93025 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-93019: Fix markup in zipfile.rst #93025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2022
Merged

gh-93019: Fix markup in zipfile.rst #93025

merged 2 commits into from
May 21, 2022

Conversation

hauntsaninja
Copy link
Contributor
@hauntsaninja hauntsaninja commented May 20, 2022 •
edited
Loading

Fixes #93019

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 20, 2022
@hauntsaninja hauntsaninja added skip news needs backport to 3.11 only security fixes and removed docs Documentation in the Doc dir awaiting review labels May 20, 2022
@AlexWaygood AlexWaygood added docs Documentation in the Doc dir awaiting review labels May 20, 2022
JelleZijlstra
JelleZijlstra approved these changes May 21, 2022
View reviewed changes
Copy link
Member
@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-05-20 at 9 35 37 PM

@JelleZijlstra JelleZijlstra merged commit 2fadde7 into python:main May 21, 2022
@miss-islington
Copy link
8000
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @hauntsaninja and @JelleZijlstra, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2fadde7e6645e45e090b0187c28877300b07cba3 3.11

@JelleZijlstra
Copy link
Member

Thanks for the fix!

@JelleZijlstra JelleZijlstra added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 21, 2022
@miss-islington
Copy link
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 21, 2022
@bedevere-bot
Copy link

GH-93039 is a backport of this pull request to the 3.11 branch.

@JelleZijlstra JelleZijlstra added the needs backport to 3.11 only security fixes label May 21, 2022
@miss-islington
Copy link
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2022
@hauntsaninja @miss-islington
pythongh-93019: Fix markup in zipfile.rst (pythonGH-93025)
167f14d 
Fixes pythonGH-93019
(cherry picked from commit 2fadde7)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@hauntsaninja hauntsaninja deleted the zipfile-docs branch May 21, 2022 04:37
@JelleZijlstra
Copy link
Member

Oops, GH didn't autoupdate and I triggered it twice.

miss-islington added a commit that referenced this pull request May 21, 2022
@miss-islington @hauntsaninja
gh-93019: Fix markup in zipfile.rst (GH-93025)
b97e28f 
Fixes GH-93019
(cherry picked from commit 2fadde7)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@hauntsaninja hauntsaninja removed the needs backport to 3.11 only security fixes label Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zipfile.ZipFile docs look broken
5 participants
@hauntsaninja @miss-islington @JelleZijlstra @bedevere-bot @AlexWaygood
0