8000 bpo-31132: Remove prlimit permission test. by benjaminp · Pull Request #9280 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

bpo-31132: Remove prlimit permission test. #9280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

benjaminp
Copy link
Contributor
@benjaminp benjaminp commented Sep 13, 2018

This test is doesn't work when the test process is privledged, which is hard to detect.

https://bugs.python.org/issue34668

This test is doesn't work when the test process is privledged, which is hard to detect.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Sep 13, 2018
@benjaminp benjaminp changed the title closes bpo-34668: Remove prlimit permission test. closes bpo-31132: Remove prlimit permission test. Sep 13, 2018
@encukou encukou self-requested a review September 13, 2018 21:18
@encukou encukou changed the title closes bpo-31132: Remove prlimit permission test. bpo-31132: Remove prlimit permission test. Sep 13, 2018
@benjaminp benjaminp closed this Sep 13, 2018
@benjaminp benjaminp reopened this Sep 13, 2018
@miss-islington
Copy link
Contributor

@benjaminp: Status check is done, and it's a failure ❌ .

Copy link
Member
@encukou encukou left a comment
8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this test doesn't add much value, and actually detecting that we don't have rights.
The code was written by Christian; he says he doesn't care much.

Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Python doesn't have to test the operating system.

@miss-islington
Copy link
Contributor

@benjaminp: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 01e0afa into master Sep 13, 2018
@miss-islington
Copy link
Contributor

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2018
This test is doesn't work when the test process is privledged, which is hard to detect.

https://bugs.python.org/issue34668
(cherry picked from commit 01e0afa)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot
Copy link

GH-9283 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2018
This test is doesn't work when the test process is privledged, which is hard to detect.

https://bugs.python.org/issue34668
(cherry picked from commit 01e0afa)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot
Copy link

GH-9284 is a backport of this pull request to the 3.6 branch.

@encukou encukou deleted the benjamin-prlimit-permission-test branch September 13, 2018 21:53
miss-islington added a commit that referenced this pull request Sep 13, 2018
This test is doesn't work when the test process is privledged, which is hard to detect.

https://bugs.python.org/issue34668
(cherry picked from commit 01e0afa)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
miss-islington added a commit that referenced this pull request Sep 13, 2018
This test is doesn't work when the test process is privledged, which is hard to detect.

https://bugs.python.org/issue34668
(cherry picked from commit 01e0afa)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0