-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-31132: Remove prlimit permission test. #9280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This test is doesn't work when the test process is privledged, which is hard to detect.
@benjaminp: Status check is done, and it's a failure ❌ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this test doesn't add much value, and actually detecting that we don't have rights.
The code was written by Christian; he says he doesn't care much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Python doesn't have to test the operating system.
@benjaminp: Status check is done, and it's a success ✅ . |
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
This test is doesn't work when the test process is privledged, which is hard to detect. https://bugs.python.org/issue34668 (cherry picked from commit 01e0afa) Co-authored-by: Benjamin Peterson <benjamin@python.org>
GH-9283 is a backport of this pull request to the 3.7 branch. |
This test is doesn't work when the test process is privledged, which is hard to detect. https://bugs.python.org/issue34668 (cherry picked from commit 01e0afa) Co-authored-by: Benjamin Peterson <benjamin@python.org>
GH-9284 is a backport of this pull request to the 3.6 branch. |
This test is doesn't work when the test process is privledged, which is hard to detect. https://bugs.python.org/issue34668 (cherry picked from commit 01e0afa) Co-authored-by: Benjamin Peterson <benjamin@python.org>
This test is doesn't work when the test process is privledged, which is hard to detect. https://bugs.python.org/issue34668 (cherry picked from commit 01e0afa) Co-authored-by: Benjamin Peterson <benjamin@python.org>
This test is doesn't work when the test process is privledged, which is hard to detect.
https://bugs.python.org/issue34668