8000 gh-92265: set meta_path and path_hooks correctly in test_reload_namespace_changed by FFY00 · Pull Request #92275 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-92265: set meta_path and path_hooks correctly in test_reload_namespace_changed #92275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2022
Merged

gh-92265: set meta_path and path_hooks correctly in test_reload_namespace_changed #92275

merged 1 commit into from
May 16, 2022

Conversation

FFY00
Copy link
Member
@FFY00 FFY00 commented May 3, 2022 •
edited by miss-islington
Loading

Previously, we were blocking the frozen imports and forcing the source
version to be used, but we did not fix up sys.meta_path or
sys.path_hooks, causing the frozen importers to leak into the source
version of the test.

Automerge-Triggered-By: GH:ericsnowcurrently

@FFY00
pythongh-92265: set meta_path and path_hooks correctly in test_reload…
ef57e04 
…_namespace_changed

Previously, we were blocking the frozen imports and forceing the source
version to be used, but we did not fix up sys.meta_path or
sys.path_hooks, causing the frozen importers to leak into the source
version of the test.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 3, 2022
@FFY00 FFY00 requested a review from ericsnowcurrently May 3, 2022 23:45
@FFY00 FFY00 added the skip news label May 3, 2022
@FFY00 FFY00 mentioned this pull request May 3, 2022
Open
ericsnowcurrently
ericsnowcurrently approved these changes May 5, 2022
View reviewed changes
Copy link
Member
@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FFY00
Copy link
Member Author
FFY00 commented May 6, 2022

Maybe @brettcannon could have a final look?

@ericsnowcurrently ericsnowcurrently changed the title gh-92265: set meta_path and path_hooks correctly in test_reload_names… gh-92265: set meta_path and path_hooks correctly in test_reload_namespace_changed May 9, 2022
@brettcannon
Copy link
Member

I'm a bit busy to review, and I trust you both to have done your due diligence to make sure it's the right solution.

@FFY00
Copy link
Member Author
FFY00 commented May 14, 2022

@ericsnowcurrently could you merge this then? Thanks!

@miss-islington miss-islington merged commit c7d6999 into python:main May 16, 2022
@ericsnowcurrently
Copy link
Member

Thanks, @FFY00!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FFY00 @brettcannon @ericsnowcurrently @bedevere-bot @miss-islington
0