-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-87452 Making returncode unreliability explicit #92181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
72565b8
Making unreliability of returncode explicit in documentation.
zitterbewegung 8b7c0c3
📜🤖 Added by blurb_it.
blurb-it[bot] c0dcc5b
Rewording with benjaminp and abadger1999 suggestions.
zitterbewegung 19390f4
Merge remote-tracking branch 'refs/remotes/origin/gh-87452' into gh-8…
zitterbewegung d62de13
Integrating rewording from benjaminp
zitterbewegung 903ae8d
📜🤖 Added by blurb_it.
blurb-it[bot] ecbe497
Merge branch 'python:main' into gh-87452
zitterbewegung c340c8f
Merge branch 'python:main' into gh-87452
zitterbewegung 517dff7
Merge branch 'python:main' into gh-87452
zitterbewegung 4adaaab
Update Doc/library/subprocess.rst
zitterbewegung ca4ea71
Updating docs for formatting issues.
zitterbewegung f7e1548
Updating for formatting issues
zitterbewegung 6357654
Removing duplicate entry
zitterbewegung 708288c
Removing duplicate news file.
zitterbewegung 41a5d22
Removing trailing whitespace
zitterbewegung a6acc97
reword the Popen.returncode text
gpshead a4eef80
no need for a NEWS entry on a documentation edit
gpshead e05f89f
Merge branch 'main' into gh-87452
gpshead eb00171
- trailingspace
gpshead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Documentation/2022-05-02-19-52-55.gh-issue-87452._N1t5V.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Here we make it explicit that the returncode attribute can be outdated and then that the returncode is most reliability found by using poll(). |
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Documentation/2022-05-02-20-59-46.gh-issue-87452._N1t5V.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Here we make it explicit that the returncode attribute can be outdated and then that the returncode is most reliability found by using poll(). |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.