10000 gh-92082: Changed a.closing from a class to a function for consistency with docs by pr-watson · Pull Request #92155 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-92082: Changed a.closing from a class to a function for consistency with docs #92155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2022
Merged

gh-92082: Changed a.closing from a class to a function for consistency with docs #92155

merged 1 commit into from
May 2, 2022

Conversation

pr-watson
Copy link
Contributor

Signed-off-by: prwatson prwatson@redhat.com

gh-92082: Changed aclosing from a class to a function as closing is listed as a function.

aclosing was originally listed as class, however, this is inconsistent as closing is listed as a function right above it. aclosing has been changed from a class to a function.

@pr-watson
Changed a.closing from a class to a function for consistency with docs
eb160fa 
Signed-off-by: prwatson <prwatson@redhat.com>
@pr-watson pr-watson requested a review from 1st1 as a code owner May 2, 2022 15:10
@ghost
Copy link
ghost commented May 2, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 2, 2022
@JelleZijlstra JelleZijlstra changed the title Changed a.closing from a class to a function for consistency with docs gh-92082: Changed a.closing from a class to a function for consistency with docs May 2, 2022
@JelleZijlstra JelleZijlstra added the needs backport to 3.10 only security fixes label May 2, 2022
@JelleZijlstra JelleZijlstra merged commit 958f21c into python:main May 2, 2022
@miss-islington
Copy link
Contributor

Thanks @Thaddeus1499 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-92163 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2022
@pr-watson @miss-islington
pythongh-92082: contextlib docs: Change aclosing from a class to a fu…
c7b4912 
…nction for consistency (pythonGH-92155)

Signed-off-by: prwatson <prwatson@redhat.com>
(cherry picked from commit 958f21c)

Co-authored-by: Thaddeus1499 <104600742+Thaddeus1499@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 2, 2022
@miss-islington @pr-watson
gh-92082: contextlib docs: Change aclosing from a class to a function…
0e9927b 
… for consistency (GH-92155)

Signed-off-by: prwatson <prwatson@redhat.com>
(cherry picked from commit 958f21c)

Co-authored-by: Thaddeus1499 <104600742+Thaddeus1499@users.noreply.github.com>
@smheidrich smheidrich mentioned this pull request May 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pr-watson @bedevere-bot @miss-islington @JelleZijlstra
0