gh-85133: Add that getenv uses os.environ #91874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
slateny
commented
May 2, 2022
Doc/library/os.rst
Outdated
| of ``os.environ``. This also applies to :func:`getenv` and :func:`getenvb`, which uses | ||
| ``os.environ`` in its implementation. | ||
| of ``os.environ``. This also applies to :func:`getenv` and :func:`getenvb`, which | ||
| respectively use ``os.environ`` and ``os.environb`` in their implementations. |
Contributor
Author
There was a problem hiding this comment.
Alternative wording can be something like
'This also applies to getenv, which uses os.environ in its implementation (and likewise for getenvb and environb).'
JelleZijlstra
approved these changes
May 2, 2022
Contributor
|
Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
GH-92145 is a backport of this pull request to the 3.10 branch. |
|
GH-92146 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 2, 2022
) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit b25352a) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 2, 2022
) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit b25352a) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
May 2, 2022
miss-islington
added a commit
that referenced
this pull request
May 2, 2022
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit b25352a) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#85133
https://docs.python.org/3/library/os.html
While implementation details seem to be generally avoided in docs, I feel that in this case it's important to be explicit to avoid being possibly misleading
The linked issue also mentions thread safety, but I believe that might be discussed here instead