8000 [3.10] Revert "[3.10] bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)" by kumaraditya303 · Pull Request #91667 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.10] Revert "[3.10] bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)" #91667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[3.10] Revert "[3.10] bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)" #91667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 47 additions & 18 deletions Lib/test/test_asyncio/test_threads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,58 +5,87 @@

from contextvars import ContextVar
from unittest import mock
from test.test_asyncio import utils as test_utils


def tearDownModule():
asyncio.set_event_loop_policy(None)


class ToThreadTests(unittest.IsolatedAsyncioTestCase):
async def test_to_thread(self):
result = await asyncio.to_thread(sum, [40, 2])
class ToThreadTests(test_utils.TestCase):
def setUp(self):
super().setUp()
self.loop = asyncio.new_event_loop()
asyncio.set_event_loop(self.loop)

def tearDown(self):
self.loop.run_until_complete(
self.loop.shutdown_default_executor())
self.loop.close()
asyncio.set_event_loop(None)
self.loop = None
super().tearDown()

def test_to_thread(self):
async def main():
return await asyncio.to_thread(sum, [40, 2])

result = self.loop.run_until_complete(main())
self.assertEqual(result, 42)

async def test_to_thread_exception(self):
def test_to_thread_exception(self):
def raise_runtime():
raise RuntimeError("test")

with self.assertRaisesRegex(RuntimeError, "test"):
async def main():
await asyncio.to_thread(raise_runtime)

async def test_to_thread_once(self):
with self.assertRaisesRegex(RuntimeError, "test"):
self.loop.run_until_complete(main())

def test_to_thread_once(self):
func = mock.Mock()

await asyncio.to_thread(func)
async def main():
await asyncio.to_thread(func)

self.loop.run_until_complete(main())
func.assert_called_once()

async def test_to_thread_concurrent(self):
def test_to_thread_concurrent(self):
func = mock.Mock()

futs = []
for _ in range(10):
fut = asyncio.to_thread(func)
futs.append(fut)
await asyncio.gather(*futs)
async def main():
futs = []
for _ in range(10):
fut = asyncio.to_thread(func)
futs.append(fut)
await asyncio.gather(*futs)

self.loop.run_until_complete(main())
self.assertEqual(func.call_count, 10)

async def test_to_thread_args_kwargs(self):
def test_to_thread_args_kwargs(self):
# Unlike run_in_executor(), to_thread() should directly accept kwargs.
func = mock.Mock()

await asyncio.to_thread(func, 'test', something=True)
async def main():
await asyncio.to_thread(func, 'test', something=True)

self.loop.run_until_complete(main())
func.assert_called_once_with('test', something=True)

async def test_to_thread_contextvars(self):
def test_to_thread_contextvars(self):
test_ctx = ContextVar('test_ctx')

def get_ctx():
return test_ctx.get()

test_ctx.set('parrot')
result = await asyncio.to_thread(get_ctx)
async def main():
test_ctx.set('parrot')
return await asyncio.to_thread(get_ctx)

result = self.loop.run_until_complete(main())
self.assertEqual(result, 'parrot')


Expand Down
2 changes: 0 additions & 2 deletions Misc/NEWS.d/next/Tests/2022-03-23-22-45-51.bpo-47104._esUq8.rst
View file
Open in desktop

This file was deleted.

0