8000 gh-90622: Prevent max_tasks_per_child use with a fork mp_context. by gpshead · Pull Request #91587 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-90622: Prevent max_tasks_per_child use with a fork mp_context. #91587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2022
Merged

gh-90622: Prevent max_tasks_per_child use with a fork mp_context. #91587

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
34f913e
Prevent max_tasks_per_child use with a fork mp_context.
gpshead Apr 16, 2022
65bf5ad
Merge branch 'main' into disallow-dynamic-process-spawn-with-fork
gpshead Apr 17, 2022
805078c
Fix max_tasks_per_child_tests to understand fork.
gpshead Apr 17, 2022
70dbc91
Merge branch 'main' into disallow-dynamic-process-spawn-with-fork
gpshead May 5, 2022
3770500
Merge branch 'main' into disallow-dynamic-process-spawn-with-fork
gpshead May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix max_tasks_per_child_tests to understand fork.
  • Loading branch information
@gpshead
gpshead committed Apr 17, 2022
commit 805078c34bbe385a50940a558c86330ae5101785
18 changes: 16 additions & 2 deletions Lib/test/test_concurrent_futures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,10 +1039,15 @@ def test_idle_process_reuse_multiple(self):
executor.shutdown()

def test_max_tasks_per_child(self):
context = self.get_context()
if context.get_start_method(allow_none=False) == "fork":
with self.assertRaises(ValueError):
self.executor_type(1, mp_context=context, max_tasks_per_child=3)
return
# not using self.executor as we need to control construction.
# arguably this could go in another class w/o that mixin.
executor = self.executor_type(
1, mp_context=self.get_context(), max_tasks_per_child=3)
1, mp_context=context, max_tasks_per_child=3)
f1 = executor.submit(os.getpid)
original_pid = f1.result()
# The worker pid remains the same as the worker could be reused
Expand All @@ -1061,11 +1066,20 @@ def test_max_tasks_per_child(self):

executor.shutdown()

def test_max_tasks_per_child_defaults_to_spawn_context(self):
# not using self.executor as we need to control construction.
# arguably this could go in another class w/o that mixin.
executor = self.executor_type(1, max_tasks_per_child=3)
self.assertEqual(executor._mp_context.get_start_method(), "spawn")

def test_max_tasks_early_shutdown(self):
context = self.get_context()
if context.get_start_method(allow_none=False) == "fork":
raise unittest.SkipTest("Incompatible with the fork start method.")
# not using self.executor as we need to control construction.
# arguably this could go in another class w/o that mixin.
executor = self.executor_type(
3, mp_context=self.get_context(), max_tasks_per_child=1)
3, mp_context=context, max_tasks_per_child=1)
futures = []
for i in range(6):
futures.append(executor.submit(mul, i, i))
Expand Down
0