8000 bpo-34573: Simplify __reduce__() of set and dict iterators. by sir-sigurd · Pull Request #9050 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-34573: Simplify __reduce__() of set and dict iterators. #9050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2018
Merged

bpo-34573: Simplify __reduce__() of set and dict iterators. #9050

merged 2 commits into from
Oct 20, 2018

Conversation

sir-sigurd
Copy link
Contributor
@sir-sigurd sir-sigurd commented Sep 4, 2018 •
edited by bedevere-bot
Loading

serhiy-storchaka
serhiy-storchaka approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member
@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@serhiy-storchaka serhiy-storchaka self-assigned this Sep 7, 2018
@vstinner
Copy link
Member

@pablogsal: You showed me an awful corner case on a similar change for OrderedDict. So now I'm scared to approve such change for other types... Would it mind to approve it? (and maybe also merge it)

pablogsal
pablogsal approved these changes Oct 20, 2018
View reviewed changes
Copy link
Member
@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That corner case is a derivative of what is being handled in #9051. I think this is fine :)

@pablogsal pablogsal merged commit 6395844 into python:master Oct 20, 2018
@sir-sigurd sir-sigurd deleted the setiter-reduce branch October 20, 2018 10:10
@serhiy-storchaka serhiy-storchaka removed their assignment Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sir-sigurd @vstinner @serhiy-storchaka @pablogsal @the-knights-who-say-ni @bedevere-bot
0